Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): use esbuild.log* options when minifying (fixes #9196) #9210

Merged
merged 1 commit into from Jul 19, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 19, 2022

Description

There is currently no way to suppress warnings during minifying CSS.
This PR makes esbuild.logLevel, esbuild.logLimit, esbuild.logOverride applied when minifying CSS.

With this PR, the warning shown at #9196 could be suppressed with the config below.

export default {
  esbuild: {
    logOverride: {
      'unsupported-css-property': 'silent'
    }
  }
}

fixes #9196

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) labels Jul 19, 2022
bluwy
bluwy approved these changes Jul 19, 2022
@patak-dev patak-dev merged commit 88baa53 into vitejs:main Jul 19, 2022
14 checks passed
@sapphi-red sapphi-red deleted the feat/css-minify-warning-suppress branch Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress warning during rendering chunks
3 participants