Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't modify config #9262

Merged
merged 5 commits into from Jul 21, 2022
Merged

fix: don't modify config #9262

merged 5 commits into from Jul 21, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jul 21, 2022

Description

worker resolved config should use origin user config

refs #9212
refs #9261

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red mentioned this pull request Jul 21, 2022
9 tasks
@sapphi-red
Copy link
Member

sapphi-red commented Jul 21, 2022

@sapphi-red sapphi-red added the bug Something isn't working label Jul 21, 2022
packages/vite/src/node/config.ts Outdated Show resolved Hide resolved
@sapphi-red sapphi-red linked an issue Jul 21, 2022 that may be closed by this pull request
7 tasks
@poyoho poyoho force-pushed the config/worker-config-override branch from 1461009 to b673cb9 Compare Jul 21, 2022
@poyoho
Copy link
Member Author

poyoho commented Jul 21, 2022

move the validate after handle config.
move create worker config after the config stable.

@poyoho poyoho changed the title fix: worker config without origin user config fix: don't modify config Jul 21, 2022
@bholmesdev
Copy link
Contributor

bholmesdev commented Jul 21, 2022

Can confirm this resolves our issue in CI! 🥳

bluwy
bluwy approved these changes Jul 21, 2022
Copy link
Member

@bluwy bluwy left a comment

We could add docs about main/worker plugins interaction in a separate PR if you prefer 🙂

@patak-dev patak-dev merged commit bbc8318 into main Jul 21, 2022
13 checks passed
@patak-dev patak-dev deleted the config/worker-config-override branch Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[astro ci] Cannot read property 'isSelfAccepting' of undefined
5 participants