Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: entries in ssr.external #9286

Merged
merged 2 commits into from Jul 22, 2022
Merged

fix: entries in ssr.external #9286

merged 2 commits into from Jul 22, 2022

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Jul 21, 2022

Fixes #9275

Description

Fixes a regression introduced by:

Only package names are valid in ssr.noExternal, as #9146 corrected, but ssr.external allows defining package names and also individual entries.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added p4-important Violate documented behavior or significantly improves performance (priority) feat: ssr labels Jul 21, 2022
@patak-dev
Copy link
Member Author

patak-dev commented Jul 21, 2022

vite-ecosystem-ci run: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/2714857134

All green, nuxt is failing because they deleted the vite-3 branch after merging:

I think we can merge and release this one in the next patch to correct the regression

bluwy
bluwy approved these changes Jul 22, 2022
@patak-dev patak-dev merged commit d420f01 into main Jul 22, 2022
18 checks passed
@patak-dev patak-dev deleted the fix/entries-in-ssr-external branch Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[astro-ci] Lit element SSR failure
2 participants