Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize async and await in code #9854

Merged
merged 1 commit into from Sep 6, 2022
Merged

Conversation

dev-itsheng
Copy link
Contributor

@dev-itsheng dev-itsheng commented Aug 26, 2022

Description

Optimized some async / await writing in the code:

  1. If a function does not have await inside, then it does not need to prepend async.
  2. If a function returns a Promise, add await in front to guarantee the execution order. Similarly, if a function returns a non-Promise value, it does not need to be preceded by await.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy approved these changes Sep 6, 2022
Copy link
Member

@bluwy bluwy left a comment

Nice find!

@bluwy bluwy changed the title refactor(*): optimize async and await in code refactor: optimize async and await in code Sep 6, 2022
@bluwy bluwy enabled auto-merge (squash) Sep 6, 2022
@bluwy bluwy merged commit 31f5ff3 into vitejs:main Sep 6, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants