Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #9855

Merged
merged 5 commits into from Aug 29, 2022
Merged

docs: fix typo #9855

merged 5 commits into from Aug 29, 2022

Conversation

dev-itsheng
Copy link
Contributor

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@@ -18,7 +18,7 @@ test('deep import with exports field', async () => {
})

test('deep import with query with exports field', async () => {
// since it is imported with `?url` it should return a url
// since it is imported with `?url` it should return an url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// since it is imported with `?url` it should return an url
// since it is imported with `?url` it should return a URL

Similar to issue above with the unsounded h, use a before a sounded u.

@@ -1,7 +1,7 @@
import { defineConfig } from 'vite'
export default defineConfig({
build: {
// make can no emit light.wasm
// make can not emit light.wasm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// make can not emit light.wasm
// make cannot emit light.wasm

@@ -394,7 +394,7 @@ function tryFsResolve(

let res: string | undefined

// if we fould postfix exist, we should first try resolving file with postfix. details see #4703.
// if we found postfix exist, we should first try resolving file with postfix. details see #4703.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// if we found postfix exist, we should first try resolving file with postfix. details see #4703.
// if a postfix exists, we should first try resolving file with postfix. details see #4703.

@@ -108,7 +108,7 @@ export function createWebSocketServer(
const port = hmrPort || 24678
const host = (hmr && hmr.host) || undefined
if (httpsOptions) {
// if we're serving the middlewares over https, the ws library doesn't support automatically creating an https server, so we need to do it ourselves
// if we're serving the middlewares over https, the ws library doesn't support automatically creating a https server, so we need to do it ourselves
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// if we're serving the middlewares over https, the ws library doesn't support automatically creating a https server, so we need to do it ourselves
// if we're serving the middlewares over https, the ws library doesn't support automatically creating an https server, so we need to do it ourselves

The original text is correct. Use an before an unsounded h.

@dev-itsheng
Copy link
Contributor Author

@tony19 Thanks for the review, I have fixed all the issues you raised.

patak-dev
patak-dev previously approved these changes Aug 29, 2022
bluwy
bluwy approved these changes Aug 29, 2022
@bluwy bluwy changed the title fix(*): Typo docs: fix typo Aug 29, 2022
@bluwy bluwy enabled auto-merge (squash) August 29, 2022 13:16
@bluwy bluwy merged commit 583f185 into vitejs:main Aug 29, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants