Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: config hook helper function #9982

merged 2 commits into from Sep 5, 2022


Copy link

@musicq musicq commented Sep 4, 2022


Add a helper function, to reduce the repeat when resolving the config hook in the resolveConfig function.

Additional context

Just a minor change.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

packages/vite/src/node/config.ts Outdated Show resolved Hide resolved
ydcjeff approved these changes Sep 5, 2022
@patak-dev patak-dev merged commit 9c1be10 into vitejs:main Sep 5, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants