Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractionated Data Not Handled With Data Frame Input to proteinSummarization() #66

Open
dnusinow opened this issue Jan 19, 2023 · 0 comments

Comments

@dnusinow
Copy link

Hello,

I'm processing data from a fractionated sample and I think I've found a bug in proteinSummarization(). I've built a data frame with all of the necessary columns and proteinSummarization() reads it just fine and returns a result data frame. However when I use a fractionated sample and include the Fraction column protein summaries are returned per fraction/run rather than across all the fractions for the plex.

I dug through the code and as best I can tell the attached patch fixes the issue. I was also able to route around it by directly calling MSconvert::MSstatsBalancedDesign myself using the default for handle_fractions option the way it's done in the various conversion functions shipped with MSstatsTMT. I'm not sure if there's a reason why handle_fractions was set to FALSE for the plain data frame code path through proteinSummarization though. Do you have any guidance on how to handle this? Thank you!

  • David Nusinow

protein_summary_fractions_data_frame.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant