Skip to content
Permalink
v0.16.1
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?

Commits on Mar 30, 2023

  1. Release of v16.0.1 (#12765)

    * Release notes for 16.0.1
    
    Signed-off-by: Manan Gupta <manan@planetscale.com>
    
    * Release commit for 16.0.1
    
    Signed-off-by: Manan Gupta <manan@planetscale.com>
    
    * feat: fix release notes folder
    
    Signed-off-by: Manan Gupta <manan@planetscale.com>
    
    * rebase after 12732
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Manan Gupta <manan@planetscale.com>
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
    GuptaManan100 and frouioui committed Mar 30, 2023
  2. [Backport] Update topo {Get,Create}Keyspace to prevent invalid keyspa…

    …ce names (#12732) (#12771)
    
    * Update topo {Get,Create}Keyspace to prevent invalid keyspace names (#12732)
    
    * Update topo {Get,Create}Keyspace to prevent invalid keyspace names
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    * embarrassing
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    * docs, release notes
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    * only validate, do not correct
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    * broader restrictions via allow-list
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    * Revert "broader restrictions via allow-list"
    
    This reverts commit 5354d4f.
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    * tighten up release notes scope
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    * Update go/vt/topo/keyspace.go
    
    Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    ---------
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    
    * update notes and comments
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    
    ---------
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    ajm188 and frouioui committed Mar 30, 2023

Commits on Mar 29, 2023

  1. Code freeze of release-16.0 (#12762)

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    GuptaManan100 committed Mar 29, 2023
  2. Addition of the 16.0.1 release summary (#12751)

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    frouioui committed Mar 29, 2023
  3. vschema ddl: add grammar to accept qualified tables (#12577) (#12748)

    Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Co-authored-by: Hormoz Kheradmand <hkdsun@users.noreply.github.com>
    frouioui and hkdsun committed Mar 29, 2023
  4. [release-16.0] Port two flaky test fixes #12603 and #12546 (#12745)

    * Flakes: Address Common Unit Test Races (#12546)
    
    * Deflake unit race tests
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Try to address glog.MaxSize race
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Test w/o using literal copy of glog.MaxSize value in CI
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Make the dialer names truly unique
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    ---------
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Use atomic.Bool for fakesqldb behavior flags (#12603)
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    Signed-off-by: Max Englander <max@planetscale.com>
    Co-authored-by: Matt Lord <mattalord@gmail.com>
    
    ---------
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    Signed-off-by: Max Englander <max@planetscale.com>
    Co-authored-by: Matt Lord <mattalord@gmail.com>
    Co-authored-by: Max Englander <max@planetscale.com>
    3 people committed Mar 29, 2023
  5. [release-16.0] Reset the current lag when closing the replication lag…

    … reader. (#12683) (#12741)
    
    * Reset the current lag when closing the replication lag reader.
    
    Signed-off-by: Johan Stenberg <johanstenberg92@github.com>
    
    * Fix tests.
    
    Signed-off-by: Johan Stenberg <johanstenberg92@github.com>
    
    ---------
    
    Signed-off-by: Johan Stenberg <johanstenberg92@github.com>
    Co-authored-by: Johan Stenberg <johanstenberg92@github.com>
    vitess-bot[bot] and johanstenberg92 committed Mar 29, 2023

Commits on Mar 28, 2023

  1. [release-16.0] Use a left join to make sure that tables with tablespa…

    …ce=innodb_system are included in the schema (#12672) (#12735)
    
    * Use a left join to make sure that tables with tablespace=innodb_system are not skipped when loading the schema (fixes #12669)
    
    Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>
    
    * Set tablespace on a test table to see if it breaks vstreamer
    
    Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>
    
    ---------
    
    Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>
    Co-authored-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>
    vitess-bot[bot] and kovyrin committed Mar 28, 2023
  2. planner: fix predicate simplifier (#12650) (#12715)

    * planner: fix predicate simplifier
    
    
    
    * predicate rewriting: add debug logging
    
    
    
    * add debug logging to make the code easier to understand
    
    
    
    * address review feedback
    
    
    
    * Update go/vt/vtgate/planbuilder/predicate_rewrite_test.go
    
    Nicer panic message
    
    
    
    
    ---------
    
    Signed-off-by: Andres Taylor <andres@planetscale.com>
    Signed-off-by: Andres Taylor <andres@taylor.se>
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Co-authored-by: Andres Taylor <andres@planetscale.com>
    frouioui and systay committed Mar 28, 2023
  3. Flakes: Use new healthy shard check in vreplication e2e tests (#12502) (

    #12740)
    
    * Use new healthy shard check in vreplication e2e tests
    
    This is needed because checking that there's a primary tablet for
    the shard in vtgate's healtcheck is no longer a reliable indicator
    that the shard has a healthy serving primary, because now a
    primary needs to initialize its sidecar database and wait for
    that to replicate via semi-sync before it becomes serving and can
    proceed to perform normal functions. So this delay could cause
    test flakiness if you required a healthy shard before continuing
    with the test.
    
    
    
    * Try to address unit test race flakes around log size
    
    They looked like this:
    WARNING: DATA RACE
    Write at 0x000005bf9b60 by goroutine 27141:
      github.com/spf13/pflag.newUint64Value()
          /home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.5/uint64.go:9 +0x5a
      github.com/spf13/pflag.(*FlagSet).Uint64Var()
          /home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.5/uint64.go:45 +0x55
      vitess.io/vitess/go/vt/log.RegisterFlags()
          /home/runner/work/vitess/vitess/go/vt/log/log.go:81 +0x64
      vitess.io/vitess/go/vt/servenv.GetFlagSetFor()
          /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:347 +0x183
      vitess.io/vitess/go/vt/servenv.ParseFlags()
          /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:326 +0x49
    ...
    Previous read at 0x000005bf9b60 by goroutine 27136:
    1744
      github.com/golang/glog.(*syncBuffer).Write()
    ...
    
    And they most often occurred in the wrangler unit tests, which makes sense
    because it creates a log of loggers.
    
    
    
    * Revert "Try to address unit test race flakes around log size"
    
    This reverts commit 51992b8.
    
    
    
    * Use external cluster vtctld in TestMigrate
    
    
    
    * Use subshell vs command output interpolation
    
    
    
    * Ingnore any config files in mysql alias
    
    
    
    ---------
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    Co-authored-by: Matt Lord <mattalord@gmail.com>
    GuptaManan100 and mattlord committed Mar 28, 2023
  4. Fixing backup tests flakiness (#12655) (#12736)

    * remove unnecessary vtorc process
    
    
    
    * Adding vtorc disabling at right place
    
    
    
    * Adding comments
    
    
    
    ---------
    
    Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
    rsajwani committed Mar 28, 2023
  5. fix fullstatus test for backward compat (#12685) (#12730)

    Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
    rsajwani committed Mar 28, 2023

Commits on Mar 27, 2023

  1. [release-16.0] Upgrade the Golang version to go1.20.2 (#12723)

    * bump go version to go1.20.2
    
    Signed-off-by: GitHub <noreply@github.com>
    
    * Update the golang version to 1.20.2
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: GitHub <noreply@github.com>
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Co-authored-by: frouioui <frouioui@users.noreply.github.com>
    Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
    3 people committed Mar 27, 2023
  2. properly escape sequence table names (#12599)

    Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
    Co-authored-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
    vitess-bot[bot] and hkdsun committed Mar 27, 2023
  3. [release-16.0] Fix panic when executing a prepare statement with ov…

    …er `65,528` parameters (#12614) (#12627)
    
    * fix type conversion in query.go for the bitMap size
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * enhance the TestHighNumberOfParams test
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * fix test comment
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
    vitess-bot[bot] and frouioui committed Mar 27, 2023
  4. [planner fix] make unknown column an error only for sharded queries (#…

    …12704) (#12725)
    
    Signed-off-by: Andres Taylor <andres@planetscale.com>
    systay committed Mar 27, 2023
  5. Run launchable only on PRs against main (#12694) (#12721)

    * feat: reenable launchable for unit_tests
    
    
    
    * feat: only run CI on PRs against main
    
    
    
    * feat: use base_ref instead of ref
    
    
    
    ---------
    
    Signed-off-by: Manan Gupta <manan@planetscale.com>
    GuptaManan100 committed Mar 27, 2023

Commits on Mar 24, 2023

  1. [release-16.0] Auto upgrade the Golang version (#12585) (#12709)

    * Auto upgrade the Golang version (#12585)
    
    * initial addition of the go_upgrade tool to detect and bump the golang version
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * update go.mod automatically
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * fix isSameMajor version issue
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * update the bootstrap version automatically
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * update the bootstrap docker image changelog
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * uncomment code
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * addition of workflow
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * addition of base to create-pull-request
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * test create PR alternative
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * add flags and getter methods
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * better PR message
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * fix no-workflow-update flag and better PR body msg
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * fix PR title, branch and body format
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * test matrix and pwd path
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * enhanced matrix
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * update_workflows option
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * update workflows independently
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * test without matrix
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Add docs to go_upgrade and re-add matrix to the workflow
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * support major version upgrade
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * do not update bootstrap version if they are the same
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * migrate to cobra instead of pflags
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * remove redundant comment
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * safety net around replaceGoVersionInCodebase to avoid unrequired upgrade
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Remove double negation in workflowUpdate flag
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Use regexp instead of mere string comparison
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Proper regexp for every string comparison
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * use better regex
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * remove useless flag and improve the auto-PR body description
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * add note in the tool usage to run the tool at the root of the repo
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * add comment in .github/workflows/update_golang_version.yml
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Apply @mattlord code suggestion
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * replace usages of old filename
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Apply suggestions from code review
    
    Co-authored-by: Matt Lord <mattalord@gmail.com>
    Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    Co-authored-by: Matt Lord <mattalord@gmail.com>
    
    * Fix regexp
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    Co-authored-by: Matt Lord <mattalord@gmail.com>
    frouioui and mattlord committed Mar 24, 2023

Commits on Mar 23, 2023

  1. [planner bugfix] add expressions to HAVING (#12668) (#12698)

    * [planner bugfix] add expressions to HAVING
    
    When a predicate contains aggregation, it should not
    be added to the WHERE clause. It should go to the
    
    
    
    * update test expecteations
    
    
    
    ---------
    
    Signed-off-by: Andres Taylor <andres@planetscale.com>
    Co-authored-by: Andres Taylor <andres@planetscale.com>
    frouioui and systay committed Mar 23, 2023
  2. Fix initialization code to also stop replication to prevent crash (#1…

    …2534) (#12691)
    
    * feat: fix initialization code to also stop replication
    
    
    
    * feat: fix tests expectations
    
    
    
    * feat: fix wrangler tests
    
    
    
    ---------
    
    Signed-off-by: Manan Gupta <manan@planetscale.com>
    GuptaManan100 committed Mar 23, 2023

Commits on Mar 22, 2023

  1. Always add columns in the Derived operator (#12634) (#12670)

    * Always add column in the derived operator
    
    
    
    * Fix plan tests expectations
    
    
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Signed-off-by: Andres Taylor <andres@planetscale.com>
    Co-authored-by: Andres Taylor <andres@planetscale.com>
    frouioui and systay committed Mar 22, 2023
  2. Mysqld.GetSchema: tolerate tables being dropped while inspecting sche…

    …ma (#12641) (#12664)
    
    * Mysqld.GetSchema: tolerate tables being dropped while inspecting schema
    
    
    
    * lack of primary key columns in STATISTICS does not mean table is dropped. It can also mean the table does not have PRIMARY KEY
    
    
    
    * populate validTds rather than rely on nil hints
    
    
    
    * re-introdce earlier check
    
    
    
    * use validTds, sync
    
    
    
    * due to many tests consistently failing, trying a different approach: we keep the table, but with empty column/key/fields info
    
    
    
    * grammar
    
    
    
    ---------
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    shlomi-noach committed Mar 22, 2023

Commits on Mar 21, 2023

  1. [gen4 planner] Make sure to not push down expressions when not possib…

    …le (#12607) (#12648)
    
    * Fix random aggregation to not select Null column
    
    
    
    * stop pushing down projections that should be evaluated at the vtgate level
    
    
    
    * undo changes to AggregateRandom
    
    
    
    * clean up code
    
    
    
    * fix executor test mock
    
    
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Signed-off-by: Andres Taylor <andres@planetscale.com>
    Co-authored-by: Andres Taylor <andres@planetscale.com>
    frouioui and systay committed Mar 21, 2023
  2. Add the vtadmin web directory to the release packages (#12639) (#12671)

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    frouioui committed Mar 21, 2023
  3. [release-16.0] Re-organize the releasenotes directory into `changel…

    …og` (#12566) (#12660)
    
    * Re-organize the `releasenotes` directory into `changelog` (#12566)
    
    * Move all release related documents to ./release and add tool to generate READMEs
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Addition of the release.go file
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * simplify release.go
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * generate the release notes in the proper place
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * modify previous mentions of docs/releasenotes
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * re-add v17.0.0 summary
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * add new release tool to release instruction and ci
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * apply review suggestions
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * simplify release notes document path
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Apply review suggestions and fix team files
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * update the changelog dir and release_notes_label workflow
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    frouioui committed Mar 21, 2023

Commits on Mar 16, 2023

  1. VStreamer: improve representation of integers in json data types (#12630

    )
    
    * Add signed and unsigned integer types to forked ason library to fix issue of integers being parsed as float64 by the source binlog parser. This results in larger integers being stored as floats on the target and sent with scientific notation in vstream events.
    
    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    
    * Use go.mod reference to the ajson module to make it easier to switch to the upstream module once changes are made there
    
    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    
    ---------
    
    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    rohit-nayak-ps committed Mar 16, 2023

Commits on Mar 13, 2023

  1. Purge logs without panicking (#12187) (#12616)

    * Purge logs without panicking
    
    
    
    * Purge logs without panicking
    
    
    
    * try moving the goroutine to the func itself
    
    
    
    ---------
    
    Signed-off-by: Andrew Mason <andrew@planetscale.com>
    ajm188 committed Mar 13, 2023

Commits on Mar 9, 2023

  1. [release-16.0] CI: extend timeouts in onlineddl_vrepl due to slow CI …

    …runners (#12583) (#12588)
    
    * CI: extend timeouts in onlineddl_vrepl due to slow CI runners
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * increase even further
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    ---------
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    vitess-bot[bot] and shlomi-noach committed Mar 9, 2023
  2. CI: increase overall test timeouts for all OnlineDDL tests (#12589)

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    vitess-bot[bot] and shlomi-noach committed Mar 9, 2023
  3. Examples, Flakes: Wait for Shard's VReplication Engine to Open (#12560)…

    … (#12581)
    
    * Examples: wait for shard's vreplication engine to open
    
    
    
    * Minor comment changes
    
    
    
    ---------
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    mattlord committed Mar 9, 2023
  4. [release-16.0] Throttler: Store Config in Global Keyspace Topo Record (

    …#12520) (#12576)
    
    * Store throttler config in global Keyspace record
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Fix unit test after ThrottlerConfig in Keyspace
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Apply changes lost in cherry picks
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Always wait for a status before the final check.
    
    We should not ever make an assumption about how quickly
    an operation will take.
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Propagate PartialResult and other errs back to client
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vtctlutil.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * Update go/test/endtoend/onlineddl/vtgate_util.go
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * fix grammar
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    ---------
    
    Signed-off-by: Matt Lord <mattalord@gmail.com>
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    Co-authored-by: Matt Lord <mattalord@gmail.com>
    Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    3 people committed Mar 9, 2023

Commits on Mar 8, 2023

  1. [release-16.0] collations: fix sorting in UCA900 collations (#12555) (#…

    …12556)
    
    * collations: fix sorting in UCA900 collations
    
    When using the fast iterator to _compare_ two strings with an UCA
    collation, we need to keep in mind that the weights in the collation are
    in BIG ENDIAN (this is the output format for the weight strings, so we
    store the weights this way), so comparing them directly will not result
    in the proper collation order. They need to be byte-swapped before they
    can be compared with an arithmetic operation!
    
    Signed-off-by: Vicent Marti <vmg@strn.cat>
    
    * collations: comment
    
    Signed-off-by: Vicent Marti <vmg@strn.cat>
    
    ---------
    
    Signed-off-by: Vicent Marti <vmg@strn.cat>
    Co-authored-by: Vicent Marti <vmg@strn.cat>
    vitess-bot[bot] and vmg committed Mar 8, 2023

Commits on Mar 7, 2023

  1. [release-16.0] Fix dubious ownership of git directory in `vitess/base…

    …` Docker build (#12530) (#12561)
    
    * Fix dubious ownership of git directory in vitess/base Docker build
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Use consistent method to copy and build vitess between base and lite
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * fix all base Dockerfiles
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
    vitess-bot[bot] and frouioui committed Mar 7, 2023

Commits on Mar 2, 2023

  1. v16: Online DDL: enforce ALGORITHM=COPY on shadow table (#12522)

    * Online DDL: enforce ALGORITHM=COPY on shadow table
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * unit tests
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * resolve conflict
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * algorithm format
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    * revert change to sql.y
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    
    ---------
    
    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    shlomi-noach committed Mar 2, 2023
  2. [release-16.0] Tooling improvements backports (#12528)

    * Improve release process post `v16.0.0 GA` code freeze (#12487)
    
    * Update the release instructions document with pre-requisites for release team
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Add Do Not Merge to release Pull Request upon creation
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * Block merge if the `Do Not Merge` label is set (#12489)
    
    * Block Merge if the  label is set
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    * fix echo syntax
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    
    ---------
    
    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    frouioui committed Mar 2, 2023
Older