Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker File Refactor #4706

Merged
merged 2 commits into from Mar 7, 2019
Merged

Conversation

dkhenry
Copy link
Contributor

@dkhenry dkhenry commented Mar 5, 2019

This PR refactors the dockerfiles used for Lite, and updates Bootstrap and Base for new versions of MySQL

Dan Kozlowski added 2 commits March 5, 2019 10:29
This commit overhauls the dockerfiles, specifically it

1. Converts the lite builds to use a multi-stage build to allow easier
automation
2. Adds in new versions of mysql and mariadb
3. Updates the dockerfiles to use the full gpg key hash to provent
collisions
4. Updates the make file with new targets

Signed-off-by: Dan Kozlowski <koz@planetscale.com>
Signed-off-by: Dan Kozlowski <koz@planetscale.com>
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I could never get build.sh to build lite images for me, so this is great.

docker/bootstrap/Dockerfile.mysql80 Show resolved Hide resolved
@sougou sougou merged commit c0bc23c into vitessio:master Mar 7, 2019
@harshit-gangal harshit-gangal deleted the dk-docker-file-refactor branch July 17, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants