Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to primary tablet if not set in VStream api #8755

Merged
merged 1 commit into from Sep 3, 2021

Conversation

harshit-gangal
Copy link
Member

Description

Now the underlying streamExecute uses plan builder to build and execute the query.
The VStream API pass on the tablet type received from the request.

Earlier it was hardcoded to use a PRIMARY tablet but now it uses what the user has passed in the request.
For query-based streaming through MySQL protocol, it is already handled for cases when tablet type is not set.

For direct VStream API calls, the fallback logic is added to use PRIMARY tablet type if not provided.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • [] Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
Copy link
Collaborator

systay commented Sep 1, 2021

@derekperkins any chance that you can check if this solves the problem for you?

@derekperkins
Copy link
Member

derekperkins commented Sep 2, 2021

I can confirm that setting the target to master solves the problem. I haven't tried primary because I thought most of the renaming PRs hit after 11.0.0

@systay systay merged commit e6f47d4 into vitessio:main Sep 3, 2021
@systay systay deleted the fix-8676 branch September 3, 2021 04:40
@systay
Copy link
Collaborator

systay commented Sep 6, 2021

this needs to be backported!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtgate: regression from v10 to v11 on stream * from queries
4 participants