Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(valid-describe-callback): remove noAsyncDescribeCallback #517

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix(valid-describe-callback): remove noAsyncDescribeCallback #517

merged 2 commits into from
Aug 26, 2024

Conversation

azu
Copy link
Contributor

@azu azu commented Aug 26, 2024

vitest allow to use async in describe's callback.

This PR just remove noAsyncDescribeCallback error.

fix #511

@azu azu mentioned this pull request Aug 26, 2024
Closed
veritem
veritem approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!!!

@veritem veritem merged commit 117312f into vitest-dev:main Aug 26, 2024
@azu azu deleted the fix/511 branch August 26, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veritem veritem veritem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async describe should not be an error
2 participants
@azu @veritem