Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): display correct line and column for web UI #1972

merged 1 commit into from
Sep 5, 2022


Copy link

@bartoszgolebiowski bartoszgolebiowski commented Sep 4, 2022

close #1499

We were displaying the wrong line and column number in the web UI.
The correct values come from:

const column = stack.sourcePos?.column  
const line  = stack.sourcePos?.line  

not from:

const column = stack.column  
const line  = stack.line  

I have updated the existing cypress test.

@edimitchel edimitchel added the feat: ui Vitest UI label Sep 5, 2022
@sheremet-va sheremet-va merged commit 9fe28a4 into vitest-dev:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: ui Vitest UI
None yet

Successfully merging this pull request may close these issues.

Line numbers completely wrong in UI test report
4 participants