Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct jsdom typo #2011

Merged
merged 1 commit into from
Sep 9, 2022
Merged

docs: correct jsdom typo #2011

merged 1 commit into from
Sep 9, 2022

Conversation

FlippingBinary
Copy link
Contributor

I tested jsdon to confirm it does not work. When I tried it, I was prompted to install undefined. It does work when the value is jsdom so I made that change here.

Perhaps there should be some error handling for when an unknown environment is specified rather than letting it attempt to install undefined?

I tested `jsdon` to confirm it does not work. When I tried it, I was prompted to install undefined. It does work when the value is `jsdom` so I made that change here.

Perhaps there should be some error handling for when an unknown environment is specified rather than letting it attempt to install undefined?
@sheremet-va sheremet-va changed the title Corrected typo docs: correct jsdom typo Sep 9, 2022
@sheremet-va sheremet-va merged commit 8cd7def into vitest-dev:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants