New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove @vitest/coverage-c8
package
#3614
feat!: remove @vitest/coverage-c8
package
#3614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide still mentions c8
through coverage ignore hints. That is correct syntax.
Lines 160 to 164 in 1e8760a
For `v8` this does not cause any issues. You can use `c8 ignore` comments with Typescript as usual: | |
<!-- eslint-skip --> | |
```ts | |
/* c8 ignore next 3 */ |
I've opened a feature request to changes this: istanbuljs/v8-to-istanbul#215
After this one is merged and released, should we add deprecation warning to |
Yes. You can add a section in the description for what to do here after we released the new major. We should also probably add a filter for c8 package to stop releasing new versions (we run with |
I guess it's fine to keep releasing new patch versions of |
e809a51
to
2011cfb
Compare
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
72dabad
to
644d17a
Compare
Can you resolve conflicts with the lockfile? |
644d17a
to
cbd7fbb
Compare
Rebased |
@vitest/coverage-v8
package #3339@vitest/coverage-c8
packagec8
from documentationcoverage.provider: 'c8'
is usedBREAKING CHANGES:
coverage.provider: 'c8'
is no longer supported. Usecoverage.provider: 'v8'
instead. See feat!: add@vitest/coverage-v8
package #3339.Actions after release
@vitest/coverage-c8
NPM package: https://docs.npmjs.com/cli/v8/commands/npm-deprecate