Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove @vitest/coverage-c8 package #3614

Merged
merged 1 commit into from Jul 11, 2023

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jun 19, 2023

BREAKING CHANGES:

Actions after release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide still mentions c8 through coverage ignore hints. That is correct syntax.

For `v8` this does not cause any issues. You can use `c8 ignore` comments with Typescript as usual:
<!-- eslint-skip -->
```ts
/* c8 ignore next 3 */

I've opened a feature request to changes this: istanbuljs/v8-to-istanbul#215

@AriPerkkio
Copy link
Member Author

After this one is merged and released, should we add deprecation warning to @vitest/coverage-c8@0.32.x NPM package? https://docs.npmjs.com/cli/v8/commands/npm-deprecate

@sheremet-va
Copy link
Member

After this one is merged and released, should we add deprecation warning to @vitest/coverage-c8@0.32.x NPM package? docs.npmjs.com/cli/v8/commands/npm-deprecate

Yes. You can add a section in the description for what to do here after we released the new major. We should also probably add a filter for c8 package to stop releasing new versions (we run with pnpm release which is a script in package.json)

@AriPerkkio
Copy link
Member Author

We should also probably add a filter for c8 package to stop releasing new versions

I guess it's fine to keep releasing new patch versions of 0.32.x of this package alongside other monorepo packages. In next major the whole package will be removed so no filters needed.

@sheremet-va sheremet-va added this to the 0.33.0 milestone Jun 19, 2023
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit cbd7fbb
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/64ad1b634037450007df9441
😎 Deploy Preview https://deploy-preview-3614--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio force-pushed the feat/remove-coverage-c8 branch 2 times, most recently from 72dabad to 644d17a Compare July 7, 2023 06:15
@sheremet-va
Copy link
Member

Can you resolve conflicts with the lockfile?

@AriPerkkio
Copy link
Member Author

Rebased main and resolved lockfiles. Good to go. 🚀

@sheremet-va sheremet-va merged commit a90d64f into vitest-dev:main Jul 11, 2023
18 checks passed
@AriPerkkio AriPerkkio deleted the feat/remove-coverage-c8 branch July 11, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants