New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Dark mode for Mojave #11

Closed
keirwilliams opened this Issue Sep 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@keirwilliams

keirwilliams commented Sep 5, 2018

Might not be an easy endeavour, but could be done with some custom styles. Could be an imitation of the iOS app's dark colour scheme.

@vitorgalvao

This comment has been minimized.

Show comment
Hide comment
@vitorgalvao

vitorgalvao Sep 5, 2018

Owner

Might not be an easy endeavour, but could be done with some custom styles.

It’s a boring lengthy task, more than anything, especially since we’re overwriting someone else’s CSS styles and I like to keep these changes with as few overrides as possible.

To put it bluntly, I appreciate the feature request but I question the usefulness of the work considering the time sink it would be with no reward. I don’t have any concrete numbers on how many people use Fog, but considering the low number of stars and issues/PRs and that I never got a single donation for it, I doubt a considerable number of people would care enough. I mean, I would use the dark mode, but right now I don’t want it bad enough to justify the investment.

I’d even be wary to say I’d accept a PR, because I’m not sure I would. Take as an example some recent styling improvements that were submitted and what I eventually ended up doing. It was basically a rewrite.

Again, thank you for the interest and the feature request. I do plan to keep working on Fog, but I’m closing the issue as this is unlikely to get done (soon?).

Owner

vitorgalvao commented Sep 5, 2018

Might not be an easy endeavour, but could be done with some custom styles.

It’s a boring lengthy task, more than anything, especially since we’re overwriting someone else’s CSS styles and I like to keep these changes with as few overrides as possible.

To put it bluntly, I appreciate the feature request but I question the usefulness of the work considering the time sink it would be with no reward. I don’t have any concrete numbers on how many people use Fog, but considering the low number of stars and issues/PRs and that I never got a single donation for it, I doubt a considerable number of people would care enough. I mean, I would use the dark mode, but right now I don’t want it bad enough to justify the investment.

I’d even be wary to say I’d accept a PR, because I’m not sure I would. Take as an example some recent styling improvements that were submitted and what I eventually ended up doing. It was basically a rewrite.

Again, thank you for the interest and the feature request. I do plan to keep working on Fog, but I’m closing the issue as this is unlikely to get done (soon?).

@vitorgalvao vitorgalvao closed this Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment