Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Code style #84

Closed
sauterl opened this issue Aug 13, 2019 · 4 comments

Comments

@sauterl
Copy link
Collaborator

commented Aug 13, 2019

I think we should agree on a code style to use.
Obviously, as it is very common I would suggest to use Google's codestyle

@sauterl sauterl added the discussion label Aug 13, 2019

@lucaro

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Cineast has been (primarily) using the google code style for many years. This has however never been enforced and therefore the styling is not always consistent...

sauterl added a commit that referenced this issue Aug 13, 2019

Resolved #83 and #84
Added informative sections to the README w.r.t. versioning and styleguide
@sauterl

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 13, 2019

Resloved by 2cd879d

@sauterl sauterl closed this Aug 13, 2019

@silvanheller

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

There's a code style file in docs/... though that should maybe be added to the readme

@lucaro

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

We can also have a gradle task which checks the code style. Though I would not add such a task to the dependencies of build, as it probably slows down the process quite a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.