Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-web-app] Drop non-generic steps setting web UI context #206

Merged
merged 1 commit into from Dec 17, 2019

Conversation

@valfirst
Copy link
Collaborator

valfirst commented Dec 5, 2019

No description provided.

@valfirst valfirst requested review from ikalinin1 and uarlouski Dec 5, 2019
@valfirst valfirst added this to the 0.2.0 milestone Dec 5, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #206 into master will decrease coverage by 5.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
- Coverage     93.52%   88.41%   -5.11%     
- Complexity     3720     3821     +101     
============================================
  Files           473      473              
  Lines         10049    10023      -26     
  Branches        830      826       -4     
============================================
- Hits           9398     8862     -536     
- Misses          507     1013     +506     
- Partials        144      148       +4
Impacted Files Coverage Δ Complexity Δ
.../org/vividus/bdd/steps/ui/web/SetContextSteps.java 100% <100%> (ø) 21 <0> (-7) ⬇️
...n/java/org/vividus/runner/KnownIssueValidator.java 0% <0%> (-100%) 0% <0%> (ø)
.../main/java/org/vividus/runner/BddStepsCounter.java 0% <0%> (-100%) 0% <0%> (ø)
...n/java/org/vividus/runner/BddScenariosCounter.java 0% <0%> (-100%) 0% <0%> (ø)
...in/java/org/vividus/bdd/steps/ExecutableSteps.java 3.7% <0%> (-96.3%) 1% <0%> (+1%)
...main/java/org/vividus/bdd/StatusStoryReporter.java 6.66% <0%> (-93.34%) 1% <0%> (+1%)
...n/java/org/vividus/bdd/steps/BddVariableSteps.java 5.35% <0%> (-92.86%) 2% <0%> (+2%)
vividus/src/main/java/org/vividus/bdd/Status.java 0% <0%> (-92.86%) 0% <0%> (ø)
...c/main/java/org/vividus/configuration/Vividus.java 0% <0%> (-92%) 0% <0%> (ø)
...c/main/java/org/vividus/bdd/steps/AssertSteps.java 10% <0%> (-90%) 1% <0%> (+1%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74556e0...b103926. Read the comment docs.

@valfirst valfirst merged commit f372f15 into master Dec 17, 2019
4 checks passed
4 checks passed
build
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 93.52%)
Details
codecov/project Absolute coverage decreased by -5.1% but relative coverage increased by +6.47% compared to 74556e0
Details
@valfirst valfirst deleted the drop-non-generic-steps-setting-context branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.