-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make install fails, no mention of ronn dependency #56
Comments
Actually, this dependency was reverted 145850a. Not sure if we can get rid of that ronn dep. I haven't looked unfortunately. |
I don't really know what travis.yml does, but the makefile definitely uses ronn still. I've been using i3blocks for a while and this is the first time I've seen it. |
|
It would be nice to not have that dependency in official releases (tarballs). For example people using autotools will run their macros and all that to get a working configure script in their release tarballs, so we don't have to run autoconf and friends. |
Indeed, I removed the versionning of i3blocks.1 because it felt redundant with the source i3blocks.1.ronn, and I noticed ruby-ronn is officially packaged in the most common distribution. @jpleau are you suggesting I should version i3blocks.1 back? |
Oh no I think the way you did it is correct. What I was suggesting was to add the i3blocks.1 (generated from ruby-ronn) in the released tarballs. It would allow people to run "make install" when downloading an official release, without requiring them to install both ruby and ruby-ronn. But people fetching from git would still have build the man page. This is similar to a project using autotools: They will not version the "configure" / "Makefile.in" files, but they will include them when they build release tarballs. Does that make more sense ? |
Yes it does make sense! |
When I tried to update to the newest version I
make clean all
which works fine. Then Isudo make install
which givesI found
ruby-ronn
in the official debian repository which appears to fulfill the dependency, and nowsudo make install
works. I'm submitting this as an issue because there doesn't appear to be any mention in the documentation of needing to installronn
before trying to build.The text was updated successfully, but these errors were encountered: