Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install fails, no mention of ronn dependency #56

Closed
kb100 opened this issue Oct 9, 2014 · 7 comments
Closed

make install fails, no mention of ronn dependency #56

kb100 opened this issue Oct 9, 2014 · 7 comments

Comments

@kb100
Copy link
Contributor

kb100 commented Oct 9, 2014

When I tried to update to the newest version I make clean all which works fine. Then I sudo make install which gives

ronn -w -r i3blocks.1.
make: ronn: Command not 
Makefile:52: recipe for target 'i3blocks.1' 
make: *** [i3blocks.1] Error 127

I found ruby-ronn in the official debian repository which appears to fulfill the dependency, and now sudo make install works. I'm submitting this as an issue because there doesn't appear to be any mention in the documentation of needing to install ronn before trying to build.

@ghost
Copy link

ghost commented Oct 9, 2014

Actually, this dependency was reverted 145850a. Not sure if we can get rid of that ronn dep. I haven't looked unfortunately.

@kb100
Copy link
Contributor Author

kb100 commented Oct 9, 2014

I don't really know what travis.yml does, but the makefile definitely uses ronn still. I've been using i3blocks for a while and this is the first time I've seen it.

@bchretien
Copy link
Contributor

ronn is used to generate the manual which is a dependency of make install (cf. 4c99f85). This should indeed appear in README.md.

@jpleau
Copy link
Contributor

jpleau commented Oct 10, 2014

It would be nice to not have that dependency in official releases (tarballs).

For example people using autotools will run their macros and all that to get a working configure script in their release tarballs, so we don't have to run autoconf and friends.

@vivien
Copy link
Owner

vivien commented Oct 14, 2014

Indeed, I removed the versionning of i3blocks.1 because it felt redundant with the source i3blocks.1.ronn, and I noticed ruby-ronn is officially packaged in the most common distribution.

@jpleau are you suggesting I should version i3blocks.1 back?

@jpleau
Copy link
Contributor

jpleau commented Oct 14, 2014

Oh no I think the way you did it is correct.

What I was suggesting was to add the i3blocks.1 (generated from ruby-ronn) in the released tarballs.

It would allow people to run "make install" when downloading an official release, without requiring them to install both ruby and ruby-ronn. But people fetching from git would still have build the man page.

This is similar to a project using autotools: They will not version the "configure" / "Makefile.in" files, but they will include them when they build release tarballs.

Does that make more sense ?

@vivien
Copy link
Owner

vivien commented Oct 14, 2014

Yes it does make sense!
I'll have to work on a make release target then.

@vivien vivien closed this as completed in e2469ab Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants