Fix error on logical border shorthand properties #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem:** "TypeError: Cannot read property 'visit' of undefined" occurs when logical border shorthand property is used. e.g. `border-inline-start: 1px solid` causes this error. When none of `<border-width>`, `<border-style>`, `<border-color>` is omitted, e.g. `border-inline-start: 1px solid blue`, this error does not happen. This error happens because default value definition of logical border properties is missing in src/resources/validation.txt. The problem existed since PR #443 "Support CSS Logical Properties".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
"TypeError: Cannot read property 'visit' of undefined" occurs when logical border shorthand property is used.
e.g.
border-inline-start: 1px solidcauses this error.When none of
<border-width>,<border-style>,<border-color>is omitted,e.g.
border-inline-start: 1px solid blue, this error does not happen.This error happens because default value definition of logical border properties is missing in src/resources/validation.txt.
The problem existed since PR #443 "Support CSS Logical Properties".