Crout Decomposition

[yuronew]

my first pull request)

[vkostyukov]

Hi Yuriy @yuronew,

Thank you for the contribution! I have few questions:

1. Is Crout method faster then triangularize().product(), which is used currently?
2. Is your implementation faster then call to existed LU decompositor: decompose(Matrices.LU_DECOMPOSITOR)[0].product()?

So, if yes, we need replace current implementation of determinant method with your Crout or default LU. The only line should be replaced is triangularize().product().

Please, try to collect some performance data for this.

[vkostyukov]

@yuronew, could you please remove "bin" and other files from pull-request? You can do it by changing the last commit git commit --amend.

[vkostyukov]

It should be CROUT_DECOMPOSITOR.

[vkostyukov]

@yuronew,

I've came through the patch. Please, make sure that you use spaces instead of tabs. Configure your IDE and try to figure out why it doesn't look like the rest of la4j's code.

Also, please follow the code convetion (by Oracle). There is no much spaces in you code. In statemens like:

a.set(i,j,5+4) -> a.set(i, j, 5 + 4);

Please, also follow my comments to improve your patch.

[vkostyukov]

There is a compile error. This method no longer exsits.

[vkostyukov]

Hi @yuronew,

Just one thing. Please remove crout method. It raises compile error.

[vkostyukov]

Hi @yuronew,

There is still a failed test:

Running org.la4j.decomposition.CroutDecompositorTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec <<< FAILURE!

Please, run mvn test to make sure all tests are passed.

[vkostyukov]

Thanks Yuriy!