Skip to content

Vlad vlad852

  • Joined on Jan 04, 2011
Vlad

FIle encoding... clone repo again.

Vlad

It broke a lot of proc ) Look into Unit::HandleProcTriggerSpell // Try handle unknown trigger spells if (sSpellMgr->GetSpellInfo(trigger_spell_id) …

Vlad

Thx)

Vlad

Winner & looser is swaped )

Vlad

Really great!

Vlad

Condition implementation is still missing? :(

Vlad

Great ^_^

Vlad

Right. It's broke procs where spell is triggered by another) Like item 50363, 54590

Vlad

@ Vincent-Michael Tell us, please, Do you plan merge master into 4.3.4, Or 4.3.4 is dead now?

Vlad
Vlad

Vincent-Michael, merge with master, plz =)

Vlad

@jackpoz We trust in you ^_^

Vlad

@Subv As you wish, and Yes, I can it) But for this case jackpoz should do it himself, to find where and why m_objectTarget become invalid. It shou…

Vlad

Really bad. It just hides real source...

vlad852 commented on pull request TrinityCore/TrinityCore#11459
Vlad

It's wrong catch. Read comments carefully.

Vlad

New crash is implemented xDhttp://pastebin.com/7Vipgc2F

Vlad

^_^ Nice.

Vlad

I'm using v3 )) v4 is bugged, v5 not ready yet.

Vlad

You are not alone xD Yep, chat and gmannonce doesn't work.

Vlad

Whole mmaps_rw in 4.3.4 xD

Vlad

IsInWorld() is more right way ^_^

Vlad

Look: Transport do teleport self and players on it to another map. Player added to map (and grid) only after MSG_MOVE_WORLDPORT_ACK by SetMap(newma…

Vlad

Yea, may be IsInWorld() is better. At least we should be ensure IsInGrid() before call PlayerRelocation.

Vlad

OK, I found what it happened: on transport teleport with player on it when player not in world yet. Can be fixed like: case TYPEID_PLAYER: if (Play…

Vlad
Crash GridObject<Player>::RemoveFromGrid
Vlad

Here will be crash with m_zoneScript due instance map and i_data deleted already

Vlad

Accessories should created just before vehicle base sends SMSG_UPDATE_OBJECT itself. For now it working: vehicle base created ->SMSG_UPDATE_OBJECT …

Something went wrong with that request. Please try again.