Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heartbeat spamming #23

Closed
wants to merge 1 commit into from
Closed

Conversation

julesghanem
Copy link

@julesghanem julesghanem commented Dec 29, 2019

In Windows, Path.Combine adds a backslash instead of a forward slash, making the heartbeat entity different from the entity in _lastHeartbeat response. Then it's not possible to skip any heartbeat. I tested and the server changes all backslashes into a forward slash. (eg: "" to "/" and "\\\" to "/"). Application.dataPath and currentScene strings look ok because they use "/" in the editor.

Also added [Serializable] to the structs because _lastHeartbeat was not being set, I believe it is required for JSON.

In Windows, Path.Combine adds a back slash instead of a forward slash, making the heartbeat entity different from the entity in _lastHeartbeat response. Then it's not possible to skip any heartbeat. I tested and the server changes all backslashes into a forward slash. (eg: "\" to "/" and "\\\\\\\" to "/"). Application.dataPath and currentScene look ok because they use "/" in the editor.
Also added [Serializable] to the structs because _lastHeartbeat was not being set, I believe it is required for JSON.
@vladfaust
Copy link
Owner

vladfaust commented Aug 15, 2020

Fixed in a20069c and a1a9dd1. Thanks!

@vladfaust vladfaust closed this Aug 15, 2020
@vladfaust vladfaust mentioned this pull request Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants