Skip to content
This repository was archived by the owner on Mar 8, 2025. It is now read-only.

Fix heartbeat spamming#23

Closed
julesghanem wants to merge 1 commit intovladfaust:masterfrom
julesghanem:master
Closed

Fix heartbeat spamming#23
julesghanem wants to merge 1 commit intovladfaust:masterfrom
julesghanem:master

Conversation

@julesghanem
Copy link

In Windows, Path.Combine adds a backslash instead of a forward slash, making the heartbeat entity different from the entity in _lastHeartbeat response. Then it's not possible to skip any heartbeat. I tested and the server changes all backslashes into a forward slash. (eg: "" to "/" and "\\\" to "/"). Application.dataPath and currentScene strings look ok because they use "/" in the editor.

Also added [Serializable] to the structs because _lastHeartbeat was not being set, I believe it is required for JSON.

In Windows, Path.Combine adds a back slash instead of a forward slash, making the heartbeat entity different from the entity in _lastHeartbeat response. Then it's not possible to skip any heartbeat. I tested and the server changes all backslashes into a forward slash. (eg: "\" to "/" and "\\\\\\\" to "/"). Application.dataPath and currentScene look ok because they use "/" in the editor.
Also added [Serializable] to the structs because _lastHeartbeat was not being set, I believe it is required for JSON.
@vladfaust
Copy link
Owner

Fixed in a20069c and a1a9dd1. Thanks!

@vladfaust vladfaust closed this Aug 15, 2020
@vladfaust vladfaust mentioned this pull request Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants