Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dynamic height #14

Closed
0xDC00 opened this issue Dec 3, 2021 · 9 comments
Closed

Feature Request: Dynamic height #14

0xDC00 opened this issue Dec 3, 2021 · 9 comments
Assignees

Comments

@0xDC00
Copy link

0xDC00 commented Dec 3, 2021

Automatically increase the height accordingly.

@vladimirgamalyan
Copy link
Owner

Do you mean output textures height? (crop unused space)

@0xDC00
Copy link
Author

0xDC00 commented Dec 3, 2021

I mean increase the height (instead split to new file).
Crop unused space also good (but size must be power of two)

@vladimirgamalyan
Copy link
Owner

I added a new --texture-size argument, the list of allowed texture sizes, the first suitable size will be used for output textures. For example: --texture-size 256x256,512x512,1024x1024

@0xDC00
Copy link
Author

0xDC00 commented Dec 4, 2021

512x128,512x256,512x512,..
512x* <= Can it be shortened like this?
Height is calculated automatically?

@vladimirgamalyan
Copy link
Owner

As I understand, the texture size you need should be power of two (128, 256, 512, 1024 and so on), so you can just use the row like 512x64,512x128,512x256,512x512,512x1024

@0xDC00
Copy link
Author

0xDC00 commented Dec 4, 2021

You're right, 512x* <=> 512x64,...
Hmm, also allow non-power-of-two too? (for save space)

@vladimirgamalyan
Copy link
Owner

vladimirgamalyan commented Dec 4, 2021

New flags (in the last release) --texture-crop-width and --texture-crop-height crop output textures, you can use --texture-size 512x65536 (the height is set to maximum supported texture size in your hardware/software) and --texture-crop-height to get 512 width and automatic height (non-power-of-two).

@vladimirgamalyan
Copy link
Owner

@0xDC00 As I understand it, the goal:

automatically increase the height accordingly

can be achieved using the new flags, do you mind that this issue can be closed?

@vladimirgamalyan
Copy link
Owner

I have closed the issue for now, feel free to reopen it if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants