From e2b8edbf3552201d34952dc3730f66b4808dfc42 Mon Sep 17 00:00:00 2001 From: Vladimir Vivien Date: Sat, 8 Jun 2024 19:00:57 +0000 Subject: [PATCH] Fix http test --- go.mod | 2 +- http/http_reader_test.go | 18 ++++++++++-------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/go.mod b/go.mod index f51a307..7cbc01b 100644 --- a/go.mod +++ b/go.mod @@ -1,3 +1,3 @@ module github.com/vladimirvivien/gexe -go 1.16 +go 1.22 diff --git a/http/http_reader_test.go b/http/http_reader_test.go index c90a414..89ea0eb 100644 --- a/http/http_reader_test.go +++ b/http/http_reader_test.go @@ -42,17 +42,17 @@ func TestHttpReader_String(t *testing.T) { func TestHttpReader_Bytes(t *testing.T) { tests := []struct { name string - data []byte + data string }{ {name: "no data"}, - {name: "string0", data: []byte("Hello World!")}, - {name: "string1", data: []byte("Hello\nWorld!")}, + {name: "string0", data: "Hello World!"}, + {name: "string1", data: "Hello\nWorld!"}, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - fmt.Fprint(w, string(test.data)) + w.Write([]byte(test.data)) })) defer ts.Close() @@ -61,13 +61,15 @@ func TestHttpReader_Bytes(t *testing.T) { t.Fatal(r.Err()) } - dataLen := len(r.Bytes()) + data := r.Bytes() + dataLen := len(data) + if dataLen != len(test.data) { - t.Fatal("unexpected server response length: ", dataLen) + t.Fatalf("unexpected server response length: %d ", dataLen) } - if strings.TrimSpace(string(r.Bytes())) != string(test.data) { - t.Fatal("unexpected server response: ", r.String()) + if strings.TrimSpace(string(data)) != test.data { + t.Fatalf("unexpected server response: %s", r.String()) } }) }