Vlad Mihalcea
vladmihalcea

Organizations

@hibernate
Jul 26, 2016
@vladmihalcea
Jul 26, 2016
@vladmihalcea
HHH-10923 Version updates
Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1464
@vladmihalcea

Applied upstream.

Jul 26, 2016
@vladmihalcea
Jul 26, 2016
@vladmihalcea
Jul 26, 2016
@vladmihalcea
HHH-10915 - NullPointerException from AbstractProducedQuery.getParameters()
Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1466
@vladmihalcea

Applied upstream.

Jul 26, 2016
@vladmihalcea
  • @dreab8 5e69823
    HHH-10915 - NullPointerException from AbstractProducedQuery.getParame…
Jul 26, 2016
@vladmihalcea
  • @dreab8 5e69823
    HHH-10915 - NullPointerException from AbstractProducedQuery.getParame…
Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1466
@vladmihalcea

Othe than the improvement that I suggested, it looks very good. I also like that we have a test for HSQLDB stored procedures.

Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1466
@vladmihalcea

I suggest an improvement here. This class should override the getParameterMetadata() method like this: @Override public ProcedureParameterMetadata …

Jul 26, 2016
Jul 26, 2016
@vladmihalcea
HHH-10888 : PluralAttribute#isAssociation returns true for @ElementCo…
Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1447
@vladmihalcea

This is already fixed by this commit. I'm going to close the issue.

Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1410
@vladmihalcea

I'm not sure that we need to change the signature here. All these methods are called from a synchronized block, so we could do something like this: f…

Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1410
@vladmihalcea

Other than what I mentioned in my comment, it looks fine.

Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1410
@vladmihalcea

Since service is volatile, we can move the main if clause in a synchronized(this) block so that we don't have to acquire a lock after the service i…

Jul 26, 2016
@vladmihalcea
HHH-10531 Fix EntityModeConverter Xml marshalling and testcase.
Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1271
@vladmihalcea

Fixed by #1272/

Jul 26, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1272
@vladmihalcea

Thanks for the PR. Applied it upstream.

Jul 26, 2016
@vladmihalcea
HHH-10532 Prevent NullPointerException + Testcase
Jul 26, 2016
@vladmihalcea
  • @jfboeuf 26df5d9
    HHH-10531 JaxbHbmTuplizerType marshalling does not conform hibernate-…
Jul 26, 2016
@vladmihalcea
  • @jfboeuf 26df5d9
    HHH-10531 JaxbHbmTuplizerType marshalling does not conform hibernate-…
Jul 25, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1454
@vladmihalcea

The ThreadLocal is indeed a hack and we need to pass that information if needed. Anyway, I think this is a good starting point that needs further i…

Jul 25, 2016
@vladmihalcea
HHH-10892 - Skip attribute conversion if value is target type while binding value
Jul 25, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1452
@vladmihalcea

This fixed cannot be applied because it's based on a wrong assumption about how Convertors should be working. See the Jira issue for more details.

Jul 25, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1454
@vladmihalcea

Thanks for the Pull Request. Did you sign the CLA?

Jul 25, 2016
vladmihalcea commented on pull request hibernate/hibernate-orm#1452
@vladmihalcea

Thanks for the Pull Request. Did you sign the CLA?

Jul 25, 2016
@vladmihalcea
Jul 25, 2016
@vladmihalcea