talkback, warn: remove impassable alerts per issue wikimedia-gadgets#94

vlakoff · May 13, 2012 · e3aedd5 · e3aedd5
1 parent 7db266c
commit e3aedd5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/modules/friendlytalkback.js b/modules/friendlytalkback.js
@@ -19,9 +19,8 @@
 	};
 
 	var callback = function( uid ) {
-		if( uid === mw.config.get("wgUserName") ){
-			alert("Is it really so bad that you're talking back to yourself?");
-			return;
+	if( uid === mw.config.get("wgUserName") && !confirm("Is it really so bad that you're talking back to yourself?") ){
+		return;
 		}
 
 		var Window = new SimpleWindow( 600, 350 );

diff --git a/modules/twinklewarn.js b/modules/twinklewarn.js
@@ -33,8 +33,8 @@ Twinkle.warn.callback = function twinklewarnCallback() {
 		alert("Your account is too new to use Twinkle.");
 		return;
 	}
-	if( mw.config.get('wgTitle').split( '/' )[0] === mw.config.get('wgUserName') ){
-		alert( 'Consider yourself warned!' );
+	if( mw.config.get('wgTitle').split( '/' )[0] === mw.config.get('wgUserName') &&
+			!confirm( 'Warning yourself can be seen as a sign of mental instability! Are you sure you want to proceed?' ) ) {
 		return;
 	}