From e3aedd5972cc7695f2bea83101b1d56c3383cf93 Mon Sep 17 00:00:00 2001 From: "This, that and the other" Date: Sun, 13 May 2012 12:36:30 +1000 Subject: [PATCH] talkback, warn: remove impassable alerts per issue #94 --- modules/friendlytalkback.js | 5 ++--- modules/twinklewarn.js | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/modules/friendlytalkback.js b/modules/friendlytalkback.js index 6228edeae..6d97e6970 100644 --- a/modules/friendlytalkback.js +++ b/modules/friendlytalkback.js @@ -19,9 +19,8 @@ }; var callback = function( uid ) { - if( uid === mw.config.get("wgUserName") ){ - alert("Is it really so bad that you're talking back to yourself?"); - return; + if( uid === mw.config.get("wgUserName") && !confirm("Is it really so bad that you're talking back to yourself?") ){ + return; } var Window = new SimpleWindow( 600, 350 ); diff --git a/modules/twinklewarn.js b/modules/twinklewarn.js index b18cfd048..ca6959f12 100644 --- a/modules/twinklewarn.js +++ b/modules/twinklewarn.js @@ -33,8 +33,8 @@ Twinkle.warn.callback = function twinklewarnCallback() { alert("Your account is too new to use Twinkle."); return; } - if( mw.config.get('wgTitle').split( '/' )[0] === mw.config.get('wgUserName') ){ - alert( 'Consider yourself warned!' ); + if( mw.config.get('wgTitle').split( '/' )[0] === mw.config.get('wgUserName') && + !confirm( 'Warning yourself can be seen as a sign of mental instability! Are you sure you want to proceed?' ) ) { return; }