Commit 1e95770
net.http: fix server_tls h2-negotiation test for default-on HTTP/2 (#27393)
test_server_tls_h2_negotiation asserted that a plain `http.fetch()` (no
`enable_http2` field) is served as HTTP/1.1. That held before #27384, but
#27384 flipped `enable_http2` to default `true`, so the client now advertises
`h2` ALPN by default and the server correctly upgrades — making the test's
`resp_h1.version() == .v1_1` assertion fail. This is currently red on master
CI (clang/gcc/tcc-linux, clang-macos).
The server behavior is correct; the test just needs to opt out explicitly.
Pass `enable_http2: false` on the HTTP/1.1 leg, which is what the test means
to exercise (server still serves h1 to a client that does not negotiate h2).
Co-authored-by: Richard Wheeler <quaesitor.scientiam@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent 95861b8 commit 1e95770
1 file changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
130 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
131 | 132 | | |
132 | | - | |
133 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
134 | 136 | | |
135 | 137 | | |
136 | 138 | | |
| |||
0 commit comments