From 8023e25bea609bd18476a276dc22e0310d2777c6 Mon Sep 17 00:00:00 2001 From: Spydr <58859306+Spydr06@users.noreply.github.com> Date: Sat, 7 Oct 2023 13:08:58 +0200 Subject: [PATCH] all: finish bootstrapping of `@VCURRENTHASH` (#19517) --- vlib/builtin/builtin.c.v | 4 ++-- vlib/v/checker/checker.v | 2 +- vlib/v/gen/c/cgen.v | 4 +--- vlib/v/gen/c/cheaders.v | 7 ------- vlib/v/util/version/version.v | 9 ++------- 5 files changed, 6 insertions(+), 20 deletions(-) diff --git a/vlib/builtin/builtin.c.v b/vlib/builtin/builtin.c.v index 019a7033da2056..da36c0454566bb 100644 --- a/vlib/builtin/builtin.c.v +++ b/vlib/builtin/builtin.c.v @@ -50,7 +50,7 @@ fn panic_debug(line_no int, file string, mod string, fn_name string, s string) { eprintln(' function: ${fn_name}()') eprintln(' message: ${s}') eprintln(' file: ${file}:${line_no}') - eprintln(' v hash: ${@VHASH}') // TODO: use @VCURRENTHASH when bootstrapped + eprintln(' v hash: ${@VCURRENTHASH}') eprintln('=========================================') $if native { C.exit(1) // TODO: native backtraces @@ -104,7 +104,7 @@ pub fn panic(s string) { } $else { eprint('V panic: ') eprintln(s) - eprintln('v hash: ${@VHASH}') // TODO: use @VCURRENTHASH when bootstrapped + eprintln('v hash: ${@VCURRENTHASH}') $if native { C.exit(1) // TODO: native backtraces } $else $if exit_after_panic_message ? { diff --git a/vlib/v/checker/checker.v b/vlib/v/checker/checker.v index ec38ceeffedc4e..f105c46dc61279 100644 --- a/vlib/v/checker/checker.v +++ b/vlib/v/checker/checker.v @@ -135,7 +135,7 @@ mut: fn_return_type ast.Type orm_table_fields map[string][]ast.StructField // known table structs // - v_current_commit_hash string // same as V_CURRENT_COMMIT_HASH + v_current_commit_hash string // same as old C.V_CURRENT_COMMIT_HASH } pub fn new_checker(table &ast.Table, pref_ &pref.Preferences) &Checker { diff --git a/vlib/v/gen/c/cgen.v b/vlib/v/gen/c/cgen.v index 6eeb18c8adce12..01e3c612e9ba81 100644 --- a/vlib/v/gen/c/cgen.v +++ b/vlib/v/gen/c/cgen.v @@ -747,9 +747,7 @@ pub fn (mut g Gen) gen_file() { } pub fn (g &Gen) hashes() string { - mut res := c_commit_hash_default.replace('@@@', version.vhash()) - res += c_current_commit_hash_default.replace('@@@', version.githash(g.pref.building_v)) - return res + return c_commit_hash_default.replace('@@@', version.vhash()) } pub fn (mut g Gen) init() { diff --git a/vlib/v/gen/c/cheaders.v b/vlib/v/gen/c/cheaders.v index d3e8b4e7152bcc..450722cfeb30dc 100644 --- a/vlib/v/gen/c/cheaders.v +++ b/vlib/v/gen/c/cheaders.v @@ -14,13 +14,6 @@ const c_commit_hash_default = ' #endif ' -// V_CURRENT_COMMIT_HASH is updated, when V is rebuilt inside a git repo. -const c_current_commit_hash_default = ' -#ifndef V_CURRENT_COMMIT_HASH - #define V_CURRENT_COMMIT_HASH "@@@" -#endif -' - const c_concurrency_helpers = ' typedef struct __shared_map __shared_map; struct __shared_map { diff --git a/vlib/v/util/version/version.v b/vlib/v/util/version/version.v index c4ff3fc6d070e5..699df1c733d0d5 100644 --- a/vlib/v/util/version/version.v +++ b/vlib/v/util/version/version.v @@ -75,11 +75,6 @@ pub fn githash(should_get_from_filesystem bool) string { } break } - mut buf := [50]u8{} - buf[0] = 0 - unsafe { - bp := &buf[0] - C.snprintf(&char(bp), 50, c'%s', C.V_CURRENT_COMMIT_HASH) - return tos_clone(bp) - } + + return @VCURRENTHASH }