checker: add checks for operator overloading #7737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta456
commented
Dec 31, 2020
Delta456
commented
Dec 31, 2020
vlib/v/checker/checker.v
Outdated
| receiver_sym := c.table.get_type_symbol(node.receiver.typ) | ||
| param_sym := c.table.get_type_symbol(node.params[1].typ) | ||
| if receiver_sym.name != param_sym.name || | ||
| param_sym.kind !in [.struct_, .alias] || receiver_sym.kind !in [.struct_, .alias] { |
Member
Author
There was a problem hiding this comment.
I had to add a check for .alias due to C interpolation in math.big module.
yuyi98
approved these changes
Dec 31, 2020
spytheman
reviewed
Dec 31, 2020
vlib/v/checker/checker.v
Outdated
| c.error('operator methods are only allowed for struct and type alias', | ||
| node.pos) | ||
| } else { | ||
| if param_sym.name != receiver_sym.name { |
Member
There was a problem hiding this comment.
if node.receiver.typ != node.params[1].typ {
Member
Author
There was a problem hiding this comment.
Thanks! It is much better!
Member
|
Good job @Delta456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.