cgen: allow assignment operators for type aliases #8086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldaeschle
requested changes
Jan 13, 2021
Member
Author
|
Ready for review. |
danieldaeschle
requested changes
Jan 13, 2021
Member
danieldaeschle
left a comment
danieldaeschle
left a comment
There was a problem hiding this comment.
could you add more tests to test edge cases?
danieldaeschle
requested changes
Jan 14, 2021
Member
Author
|
Ready for review. |
danieldaeschle
requested changes
Jan 14, 2021
danieldaeschle
approved these changes
Jan 14, 2021
Member
Author
|
Changes in error messages and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion operator overloading for alias with parent types as primitives are now disallowed as it cause a lot of confusion.
The test is in
vlib/math/big/big_test.v.