vLLM Easier cudagraph integration #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to get a correct FlashMLA full cudagraph integration in vLLM where padding for cudagraph's happens after attention metadata data building (i.e.
get_mla_metadata)The changes
and
allows
get_mla_metadatato be called with a smaller batch size than the graph was captured with since it now uses-1to mark no-work tiles instead ofparams.bThe change
makes it easier to pad out
num_splits(cumulative) since we can just do:which pads with 0 split elements instead of have to pad with 1 split elements which is more complicated: