diff --git a/.github/workflows/helm-ci.yml b/.github/workflows/helm-ci.yml index 5cabdccba..33e5ab0b9 100644 --- a/.github/workflows/helm-ci.yml +++ b/.github/workflows/helm-ci.yml @@ -111,7 +111,6 @@ jobs: run: | echo "::group::Verify Required Resources" required_resources=( - "Namespace" "ServiceAccount" "PersistentVolumeClaim" "ConfigMap" @@ -128,6 +127,7 @@ jobs: fi done echo "All required resources found" + echo "Note: Namespace is managed by Helm's --create-namespace flag" echo "::endgroup::" - name: Upload templates as artifacts diff --git a/deploy/helm/semantic-router/templates/namespace.yaml b/deploy/helm/semantic-router/templates/namespace.yaml deleted file mode 100644 index 2d03b93c4..000000000 --- a/deploy/helm/semantic-router/templates/namespace.yaml +++ /dev/null @@ -1,8 +0,0 @@ -{{- if not (lookup "v1" "Namespace" "" (include "semantic-router.namespace" .)) }} -apiVersion: v1 -kind: Namespace -metadata: - name: {{ include "semantic-router.namespace" . }} - labels: - {{- include "semantic-router.labels" . | nindent 4 }} -{{- end }} diff --git a/deploy/helm/validate-chart.sh b/deploy/helm/validate-chart.sh index ade91ed21..681e2af73 100755 --- a/deploy/helm/validate-chart.sh +++ b/deploy/helm/validate-chart.sh @@ -119,7 +119,6 @@ required_files=( "templates/deployment.yaml" "templates/service.yaml" "templates/configmap.yaml" - "templates/namespace.yaml" "templates/pvc.yaml" "templates/serviceaccount.yaml" "templates/ingress.yaml" @@ -146,7 +145,6 @@ echo "" # Test 7: Validate generated resources log_info "Validating generated Kubernetes resources..." resource_types=( - "Namespace" "ServiceAccount" "PersistentVolumeClaim" "ConfigMap" @@ -162,6 +160,7 @@ for resource in "${resource_types[@]}"; do exit 1 fi done +log_info "Note: Namespace is managed by Helm's --create-namespace flag" echo "" # Test 8: Validate Chart.yaml