From 9eabdee418a042d4d1caad04ed85a207c0e79937 Mon Sep 17 00:00:00 2001 From: bitliu Date: Fri, 14 Nov 2025 14:34:18 +0800 Subject: [PATCH 1/3] fix(helm): remove namespace template to resolve installation conflicts The namespace.yaml template with lookup function causes installation failures when the namespace already exists. Removing this template allows Helm's --create-namespace flag to handle namespace creation properly, avoiding conflicts with existing namespaces. Fixes the error: namespaces "vllm-semantic-router-system" already exists Signed-off-by: bitliu --- deploy/helm/semantic-router/templates/namespace.yaml | 8 -------- 1 file changed, 8 deletions(-) delete mode 100644 deploy/helm/semantic-router/templates/namespace.yaml diff --git a/deploy/helm/semantic-router/templates/namespace.yaml b/deploy/helm/semantic-router/templates/namespace.yaml deleted file mode 100644 index 2d03b93c4..000000000 --- a/deploy/helm/semantic-router/templates/namespace.yaml +++ /dev/null @@ -1,8 +0,0 @@ -{{- if not (lookup "v1" "Namespace" "" (include "semantic-router.namespace" .)) }} -apiVersion: v1 -kind: Namespace -metadata: - name: {{ include "semantic-router.namespace" . }} - labels: - {{- include "semantic-router.labels" . | nindent 4 }} -{{- end }} From 64efe0f07215bf1da387a748824903876d01e134 Mon Sep 17 00:00:00 2001 From: bitliu Date: Fri, 14 Nov 2025 15:19:01 +0800 Subject: [PATCH 2/3] fix(ci): update helm-ci workflow to remove namespace check Remove Namespace from required resources check since namespace.yaml template has been removed. The namespace is now managed by Helm's --create-namespace flag instead of being part of the chart templates. Signed-off-by: bitliu --- .github/workflows/helm-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/helm-ci.yml b/.github/workflows/helm-ci.yml index 5cabdccba..33e5ab0b9 100644 --- a/.github/workflows/helm-ci.yml +++ b/.github/workflows/helm-ci.yml @@ -111,7 +111,6 @@ jobs: run: | echo "::group::Verify Required Resources" required_resources=( - "Namespace" "ServiceAccount" "PersistentVolumeClaim" "ConfigMap" @@ -128,6 +127,7 @@ jobs: fi done echo "All required resources found" + echo "Note: Namespace is managed by Helm's --create-namespace flag" echo "::endgroup::" - name: Upload templates as artifacts From 8aca920d781f1397dea49484d6bfd0e5df0744c7 Mon Sep 17 00:00:00 2001 From: bitliu Date: Fri, 14 Nov 2025 15:21:23 +0800 Subject: [PATCH 3/3] fix(ci): update validate-chart.sh to remove namespace checks Remove namespace.yaml from required files list and Namespace from required resources check in the validation script. The namespace is now managed by Helm's --create-namespace flag. Signed-off-by: bitliu --- deploy/helm/validate-chart.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/deploy/helm/validate-chart.sh b/deploy/helm/validate-chart.sh index ade91ed21..681e2af73 100755 --- a/deploy/helm/validate-chart.sh +++ b/deploy/helm/validate-chart.sh @@ -119,7 +119,6 @@ required_files=( "templates/deployment.yaml" "templates/service.yaml" "templates/configmap.yaml" - "templates/namespace.yaml" "templates/pvc.yaml" "templates/serviceaccount.yaml" "templates/ingress.yaml" @@ -146,7 +145,6 @@ echo "" # Test 7: Validate generated resources log_info "Validating generated Kubernetes resources..." resource_types=( - "Namespace" "ServiceAccount" "PersistentVolumeClaim" "ConfigMap" @@ -162,6 +160,7 @@ for resource in "${resource_types[@]}"; do exit 1 fi done +log_info "Note: Namespace is managed by Helm's --create-namespace flag" echo "" # Test 8: Validate Chart.yaml