Skip to content

Conversation

@bzgoogle
Copy link
Collaborator

@bzgoogle bzgoogle commented Oct 29, 2025

Description

sparse sum may not be stable when changing the versions of jax/libtpu. FIx it by using dense sum

Tests

MMLU benchmarks has 0.871 accuracy for 1000 prompts

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@bzgoogle bzgoogle requested a review from jrplatin October 29, 2025 20:32
@bzgoogle bzgoogle marked this pull request as ready for review October 29, 2025 20:33
…u versions

Signed-off-by: bzgoogle <>
Signed-off-by: bzgoogle <beinuoz_google_com@t1v-n-fa0da4f0-w-0.us-central1-c.c.cloud-tpu-inference-test.internal>
@bzgoogle bzgoogle merged commit 0a5fed5 into main Oct 29, 2025
3 checks passed
sierraisland pushed a commit that referenced this pull request Nov 7, 2025
Signed-off-by: bzgoogle <>
Signed-off-by: bzgoogle <beinuoz_google_com@t1v-n-fa0da4f0-w-0.us-central1-c.c.cloud-tpu-inference-test.internal>
Co-authored-by: bzgoogle <beinuoz_google_com@t1v-n-fa0da4f0-w-0.us-central1-c.c.cloud-tpu-inference-test.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants