[CI/Build] Remove skip global cleanup in test_struct_output_generate.py #29022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Randall Smith <ransmith@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes the @pytest.mark.skip_global_cleanup decorator from several tests in test_struct_output_generate.py. As you've noted, these tests instantiate LLM objects and therefore utilize the GPU. By removing the decorator, you are ensuring that proper GPU cleanup occurs after these tests run, which will prevent the out-of-memory errors that were destabilizing the CI pipeline. This is a necessary and well-justified fix. The changes look good.
SageMoore
approved these changes
Nov 20, 2025
gshtras
approved these changes
Nov 20, 2025
github-actions
bot
added
the
ready
mgoin
approved these changes
Nov 20, 2025
LuminolT
pushed a commit
to LuminolT/vllm
that referenced
this pull request
Nov 21, 2025
…py (vllm-project#29022) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com> Signed-off-by: LuminolT <lumischen01@gmail.com>
ywang96
pushed a commit
to ywang96/vllm
that referenced
this pull request
Nov 23, 2025
…py (vllm-project#29022) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com>
lpapavassiliou
pushed a commit
to lpapavassiliou/vllm
that referenced
this pull request
Nov 24, 2025
…py (vllm-project#29022) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com>
RunkaiTao
pushed a commit
to RunkaiTao/vllm
that referenced
this pull request
Nov 24, 2025
…py (vllm-project#29022) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com> Signed-off-by: Runkai Tao <rt572@physics.rutgers.edu>
bringlein
pushed a commit
to bringlein/vllm
that referenced
this pull request
Nov 26, 2025
…py (vllm-project#29022) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…py (vllm-project#29022) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the @pytest.mark.skip_global_cleanup decorators for the tests that use the GPU. The decorator was created for tests that do not need GPU cleanup in order to improve CI performance. However, these tests do use the GPU and when one of the tests in this file fails, this causes the GPU to OOM when subsequent tests run, preventing the rest of the test suite to complete.
This has been observed by others as well: #27844 (comment)