-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
Gigachat 3 tool parser and tests #29905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viacheslav Barinov <viacheslav.teh@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
Documentation preview: https://vllm--29905.org.readthedocs.build/en/29905/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new tool parser for Gigachat 3 models, along with corresponding documentation and tests. The implementation for non-streaming tool calls is solid. However, the streaming implementation contains a critical bug in its JSON parsing logic that can lead to state corruption and cause streaming to fail for tool calls with complex arguments. I've provided a detailed comment on this issue. The rest of the changes, including the tests and documentation, look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Viacheslav Barinov <viacheslav.teh@gmail.com>
Signed-off-by: Viacheslav Barinov <viacheslav.teh@gmail.com>
aarnphm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not very familiar with this model family, but seems cool, thanks for the contribution.
Purpose
This PR adds a tool parser for parsing the function calls made by the Gigachat 3 models.
Models can generate only one function call without any text using format:
Test Plan
This PR also includes tests. Existing tests have not been modified or will be impacted.
Test Result
Output:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.