From 862b4190136abc48b27465cc56e33d65e0f7ad93 Mon Sep 17 00:00:00 2001 From: simon-mo Date: Fri, 5 Jul 2024 17:18:57 -0700 Subject: [PATCH] Move release wheel env var to Dockerfile instead --- .buildkite/release-pipeline.yaml | 4 ++-- Dockerfile | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.buildkite/release-pipeline.yaml b/.buildkite/release-pipeline.yaml index ca759d522650..c394f3fd7a0c 100644 --- a/.buildkite/release-pipeline.yaml +++ b/.buildkite/release-pipeline.yaml @@ -1,13 +1,13 @@ steps: - block: "Build wheels" - - label: "Build wheel - Python {{matrix.python_version}}, CUDA {{matrix.cuda_version}}" + - label: "Build wheel - Python {{matrix.python_version}}, CUDA {{matrix.cuda_version}}" agents: queue: cpu_queue commands: - "DOCKER_BUILDKIT=1 docker build --build-arg max_jobs=16 --build-arg USE_SCCACHE=1 --build-arg CUDA_VERSION={{matrix.cuda_version}} --build-arg PYTHON_VERSION={{matrix.python_version}} --tag vllm-ci:build-image --target build --progress plain ." - "mkdir artifacts" - - "docker run --rm -v $(pwd)/artifacts:/artifacts_host -e CMAKE_BUILD_TYPE=Release vllm-ci:build-image cp -r dist /artifacts_host" + - "docker run --rm -v $(pwd)/artifacts:/artifacts_host vllm-ci:build-image cp -r dist /artifacts_host" - "aws s3 cp --recursive artifacts/dist s3://vllm-wheels/$BUILDKITE_COMMIT/" matrix: setup: diff --git a/Dockerfile b/Dockerfile index f571e8be421e..feb004513959 100644 --- a/Dockerfile +++ b/Dockerfile @@ -99,6 +99,7 @@ RUN --mount=type=cache,target=/root/.cache/pip \ && rm -rf sccache.tar.gz sccache-v0.8.1-x86_64-unknown-linux-musl \ && export SCCACHE_BUCKET=vllm-build-sccache \ && export SCCACHE_REGION=us-west-2 \ + && export CMAKE_BUILD_TYPE=Release \ && sccache --show-stats \ && python3 setup.py bdist_wheel --dist-dir=dist \ && sccache --show-stats; \