New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in Redcarpet::Render::Base #516

Merged
merged 1 commit into from Sep 23, 2015

Conversation

Projects
None yet
@be9
Contributor

be9 commented Sep 11, 2015

rb_redcarpet_rbase_alloc used to allocate a struct rb_redcarpet_rndr instance
which was never freed.

This caused 312 leaked bytes (on a 64-bit machine) on every render call!

Fix memory leak in Redcarpet::Render::Base
rb_redcarpet_rbase_alloc used to allocate a rb_redcarpet_rndr instance
which was never freed.

This caused 312 leaked bytes (on a 64-bit machine) on every render call!
@recurser

This comment has been minimized.

Show comment
Hide comment
@recurser

recurser commented Sep 11, 2015

👍

@k41n

This comment has been minimized.

Show comment
Hide comment
@k41n

k41n commented Sep 12, 2015

👍

@avokhmin

This comment has been minimized.

Show comment
Hide comment
@avokhmin

avokhmin commented Sep 12, 2015

👍

@romansklenar

This comment has been minimized.

Show comment
Hide comment
@romansklenar

romansklenar Sep 23, 2015

Great job finding that leak 👍

romansklenar commented Sep 23, 2015

Great job finding that leak 👍

@be9

This comment has been minimized.

Show comment
Hide comment
@be9

be9 Sep 23, 2015

Contributor

The process of finding the leak is described in the blog post.

Contributor

be9 commented Sep 23, 2015

The process of finding the leak is described in the blog post.

@SamSaffron

This comment has been minimized.

Show comment
Hide comment
@SamSaffron

SamSaffron Sep 23, 2015

Contributor

Excellent work @be9 !

Contributor

SamSaffron commented Sep 23, 2015

Excellent work @be9 !

robin850 added a commit that referenced this pull request Sep 23, 2015

Merge pull request #516 from be9/master
Fix memory leak in Redcarpet::Render::Base

@robin850 robin850 merged commit 2d09839 into vmg:master Sep 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@robin850

This comment has been minimized.

Show comment
Hide comment
@robin850

robin850 Sep 23, 2015

Collaborator

Awesome work ! 👍 Thank you very much! ❤️

Collaborator

robin850 commented Sep 23, 2015

Awesome work ! 👍 Thank you very much! ❤️

@JuanitoFatas

This comment has been minimized.

Show comment
Hide comment
@JuanitoFatas

JuanitoFatas Sep 23, 2015

Thanks! @be9 👏

@robin850 Will you cut a new release 🙇 ?

JuanitoFatas commented Sep 23, 2015

Thanks! @be9 👏

@robin850 Will you cut a new release 🙇 ?

@tom-lord

This comment has been minimized.

Show comment
Hide comment
@tom-lord

tom-lord Sep 23, 2015

👏 👏 👏 👏 👏

tom-lord commented Sep 23, 2015

👏 👏 👏 👏 👏

robin850 added a commit that referenced this pull request Sep 23, 2015

@robin850

This comment has been minimized.

Show comment
Hide comment
@robin850

robin850 Sep 23, 2015

Collaborator

@JuanitoFatas : Yeah, a new release should be cut today or tomorrow! :-)

Collaborator

robin850 commented Sep 23, 2015

@JuanitoFatas : Yeah, a new release should be cut today or tomorrow! :-)

@JuanitoFatas

This comment has been minimized.

Show comment
Hide comment
@JuanitoFatas

JuanitoFatas Sep 23, 2015

@JuanitoFatas : Yeah, a new release should be cut today or tomorrow! :-)

Thank you so much! 😉

JuanitoFatas commented Sep 23, 2015

@JuanitoFatas : Yeah, a new release should be cut today or tomorrow! :-)

Thank you so much! 😉

@monkbroc

This comment has been minimized.

Show comment
Hide comment
@monkbroc

monkbroc Sep 24, 2015

Brilliant @be9. Great blog post too!

monkbroc commented Sep 24, 2015

Brilliant @be9. Great blog post too!

n00dle added a commit to n00dle/text-helpers that referenced this pull request Sep 24, 2015

@Davidslv

This comment has been minimized.

Show comment
Hide comment
@Davidslv

Davidslv Sep 24, 2015

Contributor

👍 awesome article, thanks for the fix

Contributor

Davidslv commented Sep 24, 2015

👍 awesome article, thanks for the fix

@dmitrytrager

This comment has been minimized.

Show comment
Hide comment
@dmitrytrager

dmitrytrager Oct 1, 2015

👍 this story is really great! ❤️ 👏

dmitrytrager commented Oct 1, 2015

👍 this story is really great! ❤️ 👏

@franciscomxs

This comment has been minimized.

Show comment
Hide comment
@franciscomxs

franciscomxs Oct 2, 2015

👍 Awesome blog post

franciscomxs commented Oct 2, 2015

👍 Awesome blog post

timhabermaas added a commit to timhabermaas/worldcubeassociation.org that referenced this pull request Oct 20, 2015

timhabermaas added a commit to timhabermaas/worldcubeassociation.org that referenced this pull request Oct 20, 2015

@vumanhcuongit

This comment has been minimized.

Show comment
Hide comment
@vumanhcuongit

vumanhcuongit commented Oct 25, 2015

👍

@asuffield asuffield referenced this pull request Nov 21, 2015

Closed

Investigate memory leaks #322

asuffield pushed a commit to asuffield/planner that referenced this pull request Nov 22, 2015

Andrew Suffield
Update redcarpet to 3.3.3
Picking up vmg/redcarpet#516 (leaks ~300 bytes
on every markdown render).

(I believe this pushing this change is sufficient for heroku to
update, but I'm not intimately familiar with heroku ruby deployments.)

asuffield pushed a commit to asuffield/planner that referenced this pull request Nov 22, 2015

Andrew Suffield
Update redcarpet to 3.3.3
Picking up vmg/redcarpet#516 (leaks ~300 bytes
on every markdown render), which might help with #322.

(I believe this pushing this change is sufficient for heroku to
update, but I'm not intimately familiar with heroku ruby deployments.)

wjordan added a commit to code-dot-org/code-dot-org that referenced this pull request Jan 14, 2016

deniseyu added a commit to codebar/planner that referenced this pull request Jan 20, 2016

Update redcarpet to 3.3.3
Picking up vmg/redcarpet#516 (leaks ~300 bytes
on every markdown render), which might help with #322.

(I believe this pushing this change is sufficient for heroku to
update, but I'm not intimately familiar with heroku ruby deployments.)
@perlun

This comment has been minimized.

Show comment
Hide comment
@perlun

perlun Aug 23, 2017

Just happened to stumble over the blog post you wrote @be9, a very good read indeed! 👍 Thanks for fixing this, and teaching us all an important lesson on how to debug the more tricky kinds of memory leaks...

perlun commented Aug 23, 2017

Just happened to stumble over the blog post you wrote @be9, a very good read indeed! 👍 Thanks for fixing this, and teaching us all an important lesson on how to debug the more tricky kinds of memory leaks...

@ArthurAzrieli

This comment has been minimized.

Show comment
Hide comment
@ArthurAzrieli

ArthurAzrieli Mar 25, 2018

@be9 your post is awesome, thank you

ArthurAzrieli commented Mar 25, 2018

@be9 your post is awesome, thank you

@lizdenhup

This comment has been minimized.

Show comment
Hide comment
@lizdenhup

lizdenhup Jun 15, 2018

great blog post on troubleshooting memory leaks @be9

lizdenhup commented Jun 15, 2018

great blog post on troubleshooting memory leaks @be9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment