Fix memory leak in Redcarpet::Render::Base#516
Merged
robin850 merged 1 commit intovmg:masterfrom Sep 23, 2015
Merged
Conversation
rb_redcarpet_rbase_alloc used to allocate a rb_redcarpet_rndr instance which was never freed. This caused 312 leaked bytes (on a 64-bit machine) on every render call!
|
👍 |
|
Great job finding that leak 👍 |
Contributor
Author
|
The process of finding the leak is described in the blog post. |
Contributor
|
Excellent work @be9 ! |
robin850
added a commit
that referenced
this pull request
Sep 23, 2015
Fix memory leak in Redcarpet::Render::Base
Collaborator
|
Awesome work ! 👍 Thank you very much! ❤️ |
|
👏 👏 👏 👏 👏 |
Collaborator
|
@JuanitoFatas : Yeah, a new release should be cut today or tomorrow! :-) |
Thank you so much! 😉 |
|
Brilliant @be9. Great blog post too! |
n00dle
added a commit
to n00dle/text-helpers
that referenced
this pull request
Sep 24, 2015
See these links for more information: * vmg/redcarpet#516 * http://www.be9.io/2015/09/21/memory-leak/
Contributor
|
👍 awesome article, thanks for the fix |
|
👍 this story is really great! ❤️ 👏 |
|
👍 Awesome blog post |
timhabermaas
added a commit
to timhabermaas/worldcubeassociation.org
that referenced
this pull request
Oct 20, 2015
|
👍 |
asuffield
added a commit
to asuffield/planner
that referenced
this pull request
Nov 22, 2015
Picking up vmg/redcarpet#516 (leaks ~300 bytes on every markdown render). (I believe this pushing this change is sufficient for heroku to update, but I'm not intimately familiar with heroku ruby deployments.)
asuffield
added a commit
to asuffield/planner
that referenced
this pull request
Nov 22, 2015
Picking up vmg/redcarpet#516 (leaks ~300 bytes on every markdown render), which might help with codebar#322. (I believe this pushing this change is sufficient for heroku to update, but I'm not intimately familiar with heroku ruby deployments.)
wjordan
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Jan 14, 2016
deniseyu
pushed a commit
to codebar/planner
that referenced
this pull request
Jan 20, 2016
Picking up vmg/redcarpet#516 (leaks ~300 bytes on every markdown render), which might help with #322. (I believe this pushing this change is sufficient for heroku to update, but I'm not intimately familiar with heroku ruby deployments.)
|
Just happened to stumble over the blog post you wrote @be9, a very good read indeed! 👍 Thanks for fixing this, and teaching us all an important lesson on how to debug the more tricky kinds of memory leaks... |
|
@be9 your post is awesome, thank you |
|
great blog post on troubleshooting memory leaks @be9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rb_redcarpet_rbase_allocused to allocate astruct rb_redcarpet_rndrinstancewhich was never freed.
This caused 312 leaked bytes (on a 64-bit machine) on every render call!