Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in Redcarpet::Render::Base #516

Merged
merged 1 commit into from Sep 23, 2015
Merged

Fix memory leak in Redcarpet::Render::Base #516

merged 1 commit into from Sep 23, 2015

Conversation

@be9
Copy link
Contributor

@be9 be9 commented Sep 11, 2015

rb_redcarpet_rbase_alloc used to allocate a struct rb_redcarpet_rndr instance
which was never freed.

This caused 312 leaked bytes (on a 64-bit machine) on every render call!

rb_redcarpet_rbase_alloc used to allocate a rb_redcarpet_rndr instance
which was never freed.

This caused 312 leaked bytes (on a 64-bit machine) on every render call!
@recurser
Copy link

@recurser recurser commented Sep 11, 2015

👍

2 similar comments
@k41n
Copy link

@k41n k41n commented Sep 12, 2015

👍

@avokhmin
Copy link

@avokhmin avokhmin commented Sep 12, 2015

👍

@romansklenar
Copy link

@romansklenar romansklenar commented Sep 23, 2015

Great job finding that leak 👍

@be9
Copy link
Contributor Author

@be9 be9 commented Sep 23, 2015

The process of finding the leak is described in the blog post.

@SamSaffron
Copy link
Contributor

@SamSaffron SamSaffron commented Sep 23, 2015

Excellent work @be9 !

robin850 added a commit that referenced this pull request Sep 23, 2015
Fix memory leak in Redcarpet::Render::Base
@robin850 robin850 merged commit 2d09839 into vmg:master Sep 23, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@robin850
Copy link
Collaborator

@robin850 robin850 commented Sep 23, 2015

Awesome work ! 👍 Thank you very much! ❤️

@JuanitoFatas
Copy link

@JuanitoFatas JuanitoFatas commented Sep 23, 2015

Thanks! @be9 👏

@robin850 Will you cut a new release 🙇 ?

@tom-lord
Copy link

@tom-lord tom-lord commented Sep 23, 2015

👏 👏 👏 👏 👏

robin850 added a commit that referenced this pull request Sep 23, 2015
@robin850
Copy link
Collaborator

@robin850 robin850 commented Sep 23, 2015

@JuanitoFatas : Yeah, a new release should be cut today or tomorrow! :-)

@JuanitoFatas
Copy link

@JuanitoFatas JuanitoFatas commented Sep 23, 2015

@JuanitoFatas : Yeah, a new release should be cut today or tomorrow! :-)

Thank you so much! 😉

@monkbroc
Copy link

@monkbroc monkbroc commented Sep 24, 2015

Brilliant @be9. Great blog post too!

n00dle added a commit to n00dle/text-helpers that referenced this pull request Sep 24, 2015
@Davidslv
Copy link
Contributor

@Davidslv Davidslv commented Sep 24, 2015

👍 awesome article, thanks for the fix

@dmitrytrager
Copy link

@dmitrytrager dmitrytrager commented Oct 1, 2015

👍 this story is really great! ❤️ 👏

@franciscomxs
Copy link

@franciscomxs franciscomxs commented Oct 2, 2015

👍 Awesome blog post

timhabermaas added a commit to timhabermaas/worldcubeassociation.org that referenced this pull request Oct 20, 2015
timhabermaas added a commit to timhabermaas/worldcubeassociation.org that referenced this pull request Oct 20, 2015
@vumanhcuongit
Copy link

@vumanhcuongit vumanhcuongit commented Oct 25, 2015

👍

asuffield added a commit to asuffield/planner that referenced this pull request Nov 22, 2015
Picking up vmg/redcarpet#516 (leaks ~300 bytes
on every markdown render).

(I believe this pushing this change is sufficient for heroku to
update, but I'm not intimately familiar with heroku ruby deployments.)
asuffield added a commit to asuffield/planner that referenced this pull request Nov 22, 2015
Picking up vmg/redcarpet#516 (leaks ~300 bytes
on every markdown render), which might help with codebar#322.

(I believe this pushing this change is sufficient for heroku to
update, but I'm not intimately familiar with heroku ruby deployments.)
wjordan added a commit to code-dot-org/code-dot-org that referenced this pull request Jan 14, 2016
deniseyu added a commit to codebar/planner that referenced this pull request Jan 20, 2016
Picking up vmg/redcarpet#516 (leaks ~300 bytes
on every markdown render), which might help with #322.

(I believe this pushing this change is sufficient for heroku to
update, but I'm not intimately familiar with heroku ruby deployments.)
@perlun
Copy link

@perlun perlun commented Aug 23, 2017

Just happened to stumble over the blog post you wrote @be9, a very good read indeed! 👍 Thanks for fixing this, and teaching us all an important lesson on how to debug the more tricky kinds of memory leaks...

@ArthurAzrieli
Copy link

@ArthurAzrieli ArthurAzrieli commented Mar 25, 2018

@be9 your post is awesome, thank you

@lizdenhup
Copy link

@lizdenhup lizdenhup commented Jun 15, 2018

great blog post on troubleshooting memory leaks @be9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.