Being serious about UTF-8 compatibility #28

Closed
wants to merge 3 commits into
from

Projects

None yet

7 participants

@shajith
Contributor
shajith commented Oct 20, 2012

Also copying incoming encoding to string yielded to the passed block.

This replaces #27, except for the autolink changes needed for supporting unicode text.

@grosser
Contributor
grosser commented Oct 26, 2012

@vmg can you get this merged ?

@vmg vmg and 1 other commented on an outdated diff Oct 26, 2012
ext/rinku/rinku.c
@@ -462,7 +482,7 @@ const char **rinku_load_tags(VALUE rb_skip)
void RUBY_EXPORT Init_rinku()
{
rb_mRinku = rb_define_module("Rinku");
+ umlaut = rb_enc_str_new("ü", 1, rb_utf8_encoding());
@vmg
vmg Oct 26, 2012 Owner

This is not the right way to go about this. Try rb_enc_asciicompat.

@shajith
shajith Oct 26, 2012 Contributor

Gotcha. I changed it to use rb_enc_asciicompat instead.

@grosser
Contributor
grosser commented Nov 18, 2013

@vmg merge maybe ?
alternatively would you be interested in zendesk or shajjith taking over maintaing the project ?

@grosser
Contributor
grosser commented Feb 3, 2014
@aguynamedben

👍 for https://github.com/tenderlove/rails_autolink, that solved the issue I was having (string.valid_encoding? returning false for a UTF-8 string after going through Rinku)

@grosser
Contributor
grosser commented Jul 24, 2014

@vmg meeerge ?

@vmg vmg referenced this pull request May 19, 2016
Merged

The great UTF8 Refactoring #52

@vmg vmg closed this in #52 May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment