Add nmake build target for windows. #108

Merged
merged 1 commit into from Apr 11, 2012

2 participants

@txdv

One can now use nmake like that: nmake /F Makefile.win
to build sundown.exe and sundown.dll easily on windows.

I had to add the MD_EXTERN define to expose the functions in the dll.
Tanoku I would like to hear some comments.

@vmg
Owner

You forgot to add the Makefile. :)

Also: buffer.h is not the right place to add those defines, and markdown.h neither, because there's an ugly dependency here... We need to come up with a better way.

@txdv

There it is. Not as beautiful as the unix makefile, yet more beautiful compared to the awful thousand vsproj files.

can't add smartypants because of getopt.h not being present on windows.

@vmg
Owner

Looks good. But we still need to find a proper place for the MD_EXTERN macro. buffer.c is certainly not the place.

If I'm not mistaken, you can specify the exported symbols for a Windows DLL on an exports file; that'd drop the requirement for the macro.

@txdv

One shouldn't use -a too often.

@txdv

I will look into this, I have never done extensive development on windows. Thanks for the suggestion.

@txdv txdv Add nmake build target for windows.
Expose functions that are needed in the windows dynamic library with
a definition file (sundown.def)
cbf052e
@txdv

Here we got, I squashed them together so it is one nice tidy commit.
Amazing, no need for source code change at all!

@vmg vmg merged commit bd06011 into vmg:master Apr 11, 2012
@vmg
Owner

YEY! Brilliant job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment