Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Escape html inside table of contents. #90

Merged
merged 1 commit into from Feb 15, 2012

Conversation

Projects
None yet
2 participants
Contributor

gregleaver commented Feb 15, 2012

The contents of the table of contents was not being escaped.

Example input:
# This & That

Was outputting:

<ul>
<li>
<a href="#toc_0">This & That</a>
</li>
</ul>

Now outputs:

<ul>
<li>
<a href="#toc_0">This &amp; That</a>
</li>
</ul>
Owner

vmg commented Feb 15, 2012

Right on! Cheers!

@vmg vmg added a commit that referenced this pull request Feb 15, 2012

@vmg vmg Merge pull request #90 from gregleaver/toc_escaping
Escape html inside table of contents.
b380583

@vmg vmg merged commit b380583 into vmg:master Feb 15, 2012

@robin850 robin850 added a commit to vmg/redcarpet that referenced this pull request Nov 15, 2014

@robin850 robin850 Avoid HTML escaping for table-of-contents' titles
By default, the HTML_TOC render object used to HTML escape titles (see
vmg/sundown#90) but in order to be consistent with other render objects,
let's avoid this escaping and provide an `:escape_html` option.

Thus, the default behavior is more expected but it's still possible to
safely display titles.

Fixes #255.
3d71044

@robin850 robin850 referenced this pull request in vmg/redcarpet Nov 15, 2014

Merged

Avoid HTML escaping for table-of-contents' titles #433

@yuku-t yuku-t added a commit to increments/greenmat that referenced this pull request Mar 25, 2015

@robin850 @yuku-t robin850 + yuku-t Avoid HTML escaping for table-of-contents' titles
By default, the HTML_TOC render object used to HTML escape titles (see
vmg/sundown#90) but in order to be consistent with other render objects,
let's avoid this escaping and provide an `:escape_html` option.

Thus, the default behavior is more expected but it's still possible to
safely display titles.

Fixes vmg/redcarpet#255.

Conflicts:
	CHANGELOG.md
	ext/greenmat/gm_render.c
102298e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment