Skip to content

Vicent Marti vmg

Organizations

GitHub libgit2
April 18, 2014
vmg commented on pull request libgit2/libgit2#2108
Vicent Marti

This is a huge improvement. Particularly love the threaded tests. :)))))))

April 18, 2014
Vicent Marti
April 18, 2014
vmg merged pull request libgit2/libgit2#2108
Vicent Marti
Make index iterator thread safe
20 commits with 2,303 additions and 1,292 deletions
April 17, 2014
vmg commented on pull request libgit2/rugged#352
Vicent Marti

Can you fix this so we can merge? :)

vmg commented on pull request libgit2/libgit2#2261
Vicent Marti

Lovely job again. Can't wait to see what's next. :)

April 16, 2014
Vicent Marti
vmg merged pull request libgit2/libgit2#2261
Vicent Marti
Support for format-patch
9 commits with 1,893 additions and 6 deletions
vmg commented on pull request libgit2/libgit2#2261
Vicent Marti

I think so. :)

vmg commented on pull request libgit2/libgit2#2270
Vicent Marti

Nailed it.

April 16, 2014
Vicent Marti
April 16, 2014
vmg merged pull request libgit2/libgit2#2270
Vicent Marti
Add GIT_BRANCH_LOCAL_AND_REMOTE to git_branch_t enum
1 commit with 4 additions and 3 deletions
April 16, 2014
vmg commented on pull request libgit2/libgit2#2270
Vicent Marti

Actually, GIT_BRANCH_ALL = (GIT_BRANCH_LOCAL | GIT_BRANCH_REMOTE) That should work on all compilers.

April 16, 2014
vmg commented on pull request libgit2/libgit2#2270
Vicent Marti

Yes to both @arrbee's suggestions.

April 16, 2014
vmg commented on pull request libgit2/libgit2#2269
Vicent Marti

Green!

April 16, 2014
Vicent Marti
April 16, 2014
vmg merged pull request libgit2/libgit2#2269
Vicent Marti
Fix core.excludesfile named .gitignore
1 commit with 101 additions and 30 deletions
April 15, 2014
vmg commented on pull request libgit2/libgit2#2269
Vicent Marti

Rerunning...

April 15, 2014
Vicent Marti
April 15, 2014
vmg merged pull request libgit2/libgit2#2235
Vicent Marti
Add cherry pick support
5 commits with 1,019 additions and 2 deletions
April 15, 2014
vmg commented on pull request libgit2/libgit2#2235
Vicent Marti

Alright, this is lovely work. :) I'm gonna merge this asap before it becomes stale and we can iron out the kinks in another PR. Thank you so much, @…

April 15, 2014
vmg commented on pull request libgit2/libgit2#2108
Vicent Marti

I don't see either change being particularly gross. I like them both. :) What I'm not starting to like is the size of this PR. I don't even know wh…

April 14, 2014
vmg commented on pull request libgit2/libgit2#2264
Vicent Marti

:)

April 14, 2014
Vicent Marti
April 14, 2014
vmg merged pull request libgit2/libgit2#2264
Vicent Marti
Correct C90 warnings
1 commit with 5 additions and 3 deletions
April 14, 2014
vmg commented on pull request libgit2/libgit2#2261
Vicent Marti

This is brilliant work by the way. Just that small nitpick and I think this is ready to merge. :)

April 14, 2014
vmg commented on pull request libgit2/libgit2#2261
Vicent Marti

...and it returns a pointer to the stack buffer so you can pass it directly in the varargs in giterr_set. char buf[GIT_OID_HEXSZ + 1]; giterr_set(G…

April 14, 2014
vmg commented on pull request libgit2/libgit2#2261
Vicent Marti

git_oid_tostr does the same thing as these two lines :)

April 14, 2014
vmg commented on pull request vmg/clar#55
Vicent Marti

Damn right. Thanks for spotting this!

April 14, 2014
vmg pushed to master at vmg/clar
Vicent Marti
April 14, 2014
vmg merged pull request vmg/clar#55
Vicent Marti
Make -f option action="store_true" so that it does not consume the next argument.
1 commit with 1 addition and 1 deletion
Something went wrong with that request. Please try again.