Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Modify vmtksurfaceendclipper to clip based on centerline information #200
This modification provides a means to use the normal information from the frenet frame of reference along the centerline to clip at inlet and outlet locations. The seed selection requires that the users knows the inlet and outlet direction used in the centerline generation such that the proper normal direction is applied in the clipping.
The issue with the current implementation of surfaceendclipper is two things.
The additions also includes removing the use of python dictionaries in the for loop.
Thanks for this PR @kayarre! I'm really sorry it took so long to review this! It works really well. Nice Job!
Also, I meant to just push a few small changes to your PR before merging it (just updated the docstring and simplified some expressions), but it appears that I have royally screwed up and somehow merged in every commit to master from the point you branched to now... Not entirely sure how that happened. Sorry about the confusion, will fix now.