remove vmtkimagereader InputDirectoryName option #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an immediate removal of both the python and c++ code which handled reading in dicom files specified from a directory name. This was performed for a number of reason: 1) it is now best practice to use the ITKIO module for loading files. This utility can be generally regarded as being more accurate (by keeping translation and rotation matrices aligned). 2) incompatibility with VTK 8.1.0. With c++ 14 onwards and VTK 8.1.0+, the forward declarations in the vtkDICOMImageReader.h were somehow overriding the full definitions when we included the DICOMParser.h files in our derived class. 3) Using a simple directory name can lead to ambiguity if there is more than one dicom image series in a directory. This is handled transparently by ITKIO by requiring that the exact file/series desired is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an immediate removal of both the python and c++ code which
handled reading in dicom files specified from a directory name. This was
performed for a number of reason:
it is now best practice to use the ITKIO module for loading files.
This utility can be generally regarded as being more accurate (by
keeping translation and rotation matrices aligned).
incompatibility with VTK 8.1.0. With c++ 14 onwards and VTK 8.1.0+,
the forward declarations in the vtkDICOMImageReader.h were somehow
overriding the full definitions when we included the DICOMParser.h files
in our derived class.
Using a simple directory name can lead to ambiguity if there is more
than one dicom image series in a directory. This is handled
transparently by ITKIO by requiring that the exact file/series desired is
specified.
addresses #198 and #208