New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vmtkimagereader InputDirectoryName option #220

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
1 participant
@rlizzo
Member

rlizzo commented Jan 11, 2018

This is an immediate removal of both the python and c++ code which
handled reading in dicom files specified from a directory name. This was
performed for a number of reason:

  1. it is now best practice to use the ITKIO module for loading files.
    This utility can be generally regarded as being more accurate (by
    keeping translation and rotation matrices aligned).

  2. incompatibility with VTK 8.1.0. With c++ 14 onwards and VTK 8.1.0+,
    the forward declarations in the vtkDICOMImageReader.h were somehow
    overriding the full definitions when we included the DICOMParser.h files
    in our derived class.

  3. Using a simple directory name can lead to ambiguity if there is more
    than one dicom image series in a directory. This is handled
    transparently by ITKIO by requiring that the exact file/series desired is
    specified.

addresses #198 and #208

remove vmtkimagereader InputDirectoryName option
This is an immediate removal of both the python and c++ code which
handled reading in dicom files specified from a directory name. This was
performed for a number of reason:

1) it is now best practice to use the ITKIO module for loading files.
This utility can be generally regarded as being more accurate (by
keeping translation and rotation matrices aligned).

2) incompatibility with VTK 8.1.0. With c++ 14 onwards and VTK 8.1.0+,
the forward declarations in the vtkDICOMImageReader.h were somehow
overriding the full definitions when we included the DICOMParser.h files
in our derived class.

3) Using a simple directory name can lead to ambiguity if there is more
than one dicom image series in a directory. This is handled
transparently by ITKIO by requiring that the exact file/series desired is
specified.

@rlizzo rlizzo merged commit 5694f5e into vmtk:master Jan 11, 2018

@rlizzo rlizzo deleted the rlizzo:remove-vtkdicomimagereader branch Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment