From 77dc157cab8378d19133c4affec671bce2a7e953 Mon Sep 17 00:00:00 2001
From: Steve Haar <info@stevehaar.com>
Date: Tue, 8 Feb 2022 10:12:55 -0600
Subject: [PATCH] feat: add placeholder to datagrid string filter

This is a backport of 1cffda0464b8f13b44b9415f3f1e4b5210847e3b.

Committed-by: Kevin Buhmann <kbuhmann@vmware.com>
---
 .../built-in/filters/datagrid-string-filter.spec.ts        | 7 +++++++
 .../datagrid/built-in/filters/datagrid-string-filter.ts    | 1 +
 2 files changed, 8 insertions(+)

diff --git a/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.spec.ts b/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.spec.ts
index ce4b4d2325..7aa49584d7 100644
--- a/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.spec.ts
+++ b/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.spec.ts
@@ -122,6 +122,13 @@ export default function (): void {
       expect(input.getAttribute('aria-label')).toBe('Filter items');
       tick();
     }));
+
+    it('has placeholder on the input', fakeAsync(function () {
+      openFilter();
+      const input: HTMLInputElement = document.querySelector("input[type='text']");
+      expect(input.getAttribute('placeholder')).toBe('Filter items');
+      tick();
+    }));
   });
 }
 
diff --git a/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.ts b/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.ts
index 52f3048cfc..db80598693 100644
--- a/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.ts
+++ b/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.ts
@@ -29,6 +29,7 @@ import { DatagridStringFilterImpl } from './datagrid-string-filter-impl';
         [(ngModel)]="value"
         class="clr-input"
         [attr.aria-label]="commonStrings.keys.filterItems"
+        [placeholder]="commonStrings.keys.filterItems"
       />
     </clr-dg-filter>
   `,