Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Rust kit attribute macro to worker #43

Closed
Angelmmiguel opened this issue Nov 24, 2022 · 0 comments · Fixed by #48
Closed

Rename Rust kit attribute macro to worker #43

Angelmmiguel opened this issue Nov 24, 2022 · 0 comments · Fixed by #48
Assignees
Labels
🚨 breaking change Introduces a breaking change in the project 🚀 enhancement New feature or request

Comments

@Angelmmiguel
Copy link
Contributor

In the initial versions of this project, we used handler as the attribute macro for the Rust kit. However, our documentation references worker as the right term for this kind of Request / Respose functions.

This will be a breaking change. Since we are still defining the final API, it's fine to apply those at this moment.

To complete this task you will need to:

  • Rename the kits/rust/handler project to kits/rust/worker. This includes all references in Cargo.toml, kits/rust/Cargo.toml, kits/rust/handler/Cargo.toml and any place in which we import it.
  • Change the macro attribute name and all its references in kits/rust/worker
  • Update the exported name in kits/rust/src/lib.rs
  • Update all the examples in the documentation
  • Update the examples in the examples folder
@Angelmmiguel Angelmmiguel added 🚀 enhancement New feature or request 🚨 breaking change Introduces a breaking change in the project labels Nov 24, 2022
@Angelmmiguel Angelmmiguel self-assigned this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking change Introduces a breaking change in the project 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant