Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update octant plugin installation guide #1473

Merged
merged 1 commit into from Nov 4, 2020

Conversation

mengdie-song
Copy link
Contributor

Update octant plugin installation guide and simplify
the steps to deploy octant and antrea-octant-plugin as a Pod.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

antoninbas
antoninbas previously approved these changes Nov 2, 2020
docs/octant-plugin-installation.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #1473 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1473      +/-   ##
==========================================
- Coverage   56.42%   56.39%   -0.03%     
==========================================
  Files         126      126              
  Lines       11662    11662              
==========================================
- Hits         6580     6577       -3     
- Misses       4451     4453       +2     
- Partials      631      632       +1     
Flag Coverage Δ
integration-tests 45.78% <ø> (ø)
unit-tests 42.26% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/storage/ram/store.go 77.44% <0.00%> (-1.51%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 71.71% <0.00%> (-0.15%) ⬇️

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the change

@mengdie-song
Copy link
Contributor Author

/test-all

@mengdie-song
Copy link
Contributor Author

/test-conformance

Update octant plugin installation guide and simplify
the steps to deploy octant and antrea-octant-plugin as a Pod.
@mengdie-song mengdie-song merged commit d6aca2d into antrea-io:master Nov 4, 2020
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Nov 10, 2020
Update octant plugin installation guide and simplify
the steps to deploy octant and antrea-octant-plugin as a Pod.
antoninbas pushed a commit that referenced this pull request Nov 11, 2020
Update octant plugin installation guide and simplify
the steps to deploy octant and antrea-octant-plugin as a Pod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants