Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync chart with bitnami/kubeapps chart (version 7.1.8) #3214

Merged
merged 2 commits into from Jul 29, 2021

Conversation

kubeapps-bot
Copy link
Collaborator

Description of the change

This is an automatic PR for synchronizing the changes performed externally at the bitnami/kubeapps official chart to the Kubeapps development version.

Benefits

The Kubeapps development chart will get the newest changes, including image version updates and other updates.

Possible drawbacks

Although unlikely, some changes implemented by the Bitnami team may not be 100% compatible with the current Kubeapps version.

Applicable issues

N/A

Additional information

This PR is marked as a draft until a Kubeapps maintainer manually reviews it.

kubeapps-bot and others added 2 commits July 28, 2021 20:54
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia marked this pull request as ready for review July 28, 2021 22:43
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming those templates/tests/* were removed upstream because they were broken or are no longer used?

@absoludity absoludity merged commit 8c02d3b into master Jul 29, 2021
@absoludity absoludity deleted the sync-chart-changes-7.1.8 branch July 29, 2021 00:05
@antgamdia
Copy link
Contributor

Bitnami people told us they needed to remove these files to definitely get rid of the helms hooks. These files were used in the test_chart_render CI step, but now it is executing just the helm template command.

@absoludity
Copy link
Contributor

absoludity commented Jul 30, 2021

Makes sense. Thanks. I guess that means the bitnami repo no longer supports helm tests at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants