Move operator integration test to its own directory and test separately. #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
script/e2e-test.sh
Outdated
Comment on lines
430
to
431
| installOrUpgradeKubeapps bitnami/kubeapps \ | ||
| "--set" "featureFlags.operators=true" |
There was a problem hiding this comment.
That is a brilliant idea Michael!
Kubeapps resources are recreated to enable operators without the need to deploy the whole cluster again.
antgamdia
approved these changes
Jan 14, 2022
|
|
||
| ## Upgrade and run operator test | ||
| # Operators are not supported in GKE 1.14 and flaky in 1.15, skipping test | ||
| if [[ -z "${GKE_BRANCH-}" ]] && [[ -n "${TEST_OPERATORS-}" ]]; then |
There was a problem hiding this comment.
Just wondering if skipping this test in GKE is still required (as now we are in more recent versions). Anyway, perhaps worths a separate PR not to be mixing up CI potentially breaking changes :P
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
I wanted to ensure that we are testing Kubeapps in the default setup (ie. without any k8s API proxying) while also ensuring we still have the confidence of CI for basic operator support. Initially I was thinking we'd need to either run two jobs (not great, given the failures), but then realised we can simply run the main tests first, then update Kubeapps with the operator support and run the operator test at the end.
This enables the best of both worlds, and we can still switch off the operator test if we like (when a decision is made).
Benefits
All the main CI tests for Kubeapps run without any access to the k8s API.
Possible drawbacks
None that I can see.
Applicable issues
Additional information